Bug 1549667 - [mips64] Adding missing 'breaks' to 'switch' statements.
☠☠ backed out by d4a9de6a57b7 ☠ ☠
authorYu Yin <yuyin-hf@loongson.cn>
Fri, 10 May 2019 09:41:48 +0300
changeset 532167 5d580fa5d7531f846acac842f7c9eec92a52a460
parent 532166 b661a2bf1626fcf9cef6915dffbff50a6c6dc289
child 532168 acf19aefc4d23947c202b2eaf445b7ef332d7777
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1549667
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1549667 - [mips64] Adding missing 'breaks' to 'switch' statements. Reviewers: jandem Reviewed By: jandem Subscribers: jandem Bug #: 1549667 Differential Revision: https://phabricator.services.mozilla.com/D30167
js/src/jit/mips64/CodeGenerator-mips64.cpp
--- a/js/src/jit/mips64/CodeGenerator-mips64.cpp
+++ b/js/src/jit/mips64/CodeGenerator-mips64.cpp
@@ -75,16 +75,17 @@ void CodeGenerator::visitUnbox(LUnbox* u
       case MIRType::String:
         masm.unboxString(inputReg, result);
         break;
       case MIRType::Symbol:
         masm.unboxSymbol(inputReg, result);
         break;
       case MIRType::BigInt:
         masm.unboxBigInt(inputReg, result);
+        break;
       default:
         MOZ_CRASH("Given MIRType cannot be unboxed.");
     }
     return;
   }
 
   Address inputAddr = ToAddress(input);
   switch (mir->type()) {
@@ -100,16 +101,17 @@ void CodeGenerator::visitUnbox(LUnbox* u
     case MIRType::String:
       masm.unboxString(inputAddr, result);
       break;
     case MIRType::Symbol:
       masm.unboxSymbol(inputAddr, result);
       break;
     case MIRType::BigInt:
       masm.unboxBigInt(inputAddr, result);
+      break;
     default:
       MOZ_CRASH("Given MIRType cannot be unboxed.");
   }
 }
 
 void CodeGeneratorMIPS64::splitTagForTest(const ValueOperand& value,
                                           ScratchTagScope& tag) {
   masm.splitTag(value.valueReg(), tag);