Bug 1536229: Remove NS_RELEASE_ASSERT that is being tripped and seems to be unnecessary. r=rhunt
authorBas Schouten <bschouten@mozilla.com>
Sat, 27 Apr 2019 17:31:49 +0000
changeset 530893 5d43e71f877076bdfc86676ac3f9944dca277097
parent 530892 42f3c8e92866d864095e3c80f25d4fefada97d14
child 530894 6cab2047fa7a7162b258fdaf5cb46e71ce1d70ff
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrhunt
bugs1536229
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1536229: Remove NS_RELEASE_ASSERT that is being tripped and seems to be unnecessary. r=rhunt Differential Revision: https://phabricator.services.mozilla.com/D29105
gfx/2d/SourceSurfaceCapture.cpp
--- a/gfx/2d/SourceSurfaceCapture.cpp
+++ b/gfx/2d/SourceSurfaceCapture.cpp
@@ -86,21 +86,16 @@ RefPtr<SourceSurface> SourceSurfaceCaptu
     return mResolved;
   }
 
   BackendType backendType = aBackendType;
   if (backendType == BackendType::NONE) {
     backendType = mRefDT->GetBackendType();
   }
 
-  // If on the paint thread, we require that the owning DrawTarget be detached
-  // from this snapshot. This roughly approximates an assert that nothing can
-  // mutate the snapshot.
-  MOZ_RELEASE_ASSERT(NS_IsMainThread() || !mOwner);
-
   // Note: SurfaceType is not 1:1 with BackendType, so we can't easily decide
   // that they match. Instead we just cache the first thing to be requested.
   // We ensured no mResolved existed before.
   mResolved = ResolveImpl(backendType);
 
   return mResolved;
 }