Bug 1420462 - Fix rooting hazard. r=red
authorJan de Mooij <jdemooij@mozilla.com>
Sat, 16 Dec 2017 21:49:40 -0600
changeset 448384 5d203926da51a7e949a20818664b19d5b115572d
parent 448383 0b42ea549d67069a702a02df377b9e889d49840e
child 448385 57f93cbd4e918b124e00d844c4ec8d8fa1f9a748
child 448398 bacb75596acb612fdd7383607f7e9033bc21b8e7
child 448433 baa80d498effd0665b0aafd21714f3b7f0965e10
push id8527
push userCallek@gmail.com
push dateThu, 11 Jan 2018 21:05:50 +0000
treeherdermozilla-beta@95342d212a7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersred
bugs1420462
milestone59.0a1
first release with
nightly linux32
5d203926da51 / 59.0a1 / 20171217100047 / files
nightly linux64
5d203926da51 / 59.0a1 / 20171217100047 / files
nightly mac
5d203926da51 / 59.0a1 / 20171217100047 / files
nightly win32
5d203926da51 / 59.0a1 / 20171217100047 / files
nightly win64
5d203926da51 / 59.0a1 / 20171217100047 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1420462 - Fix rooting hazard. r=red
js/src/builtin/Object.cpp
--- a/js/src/builtin/Object.cpp
+++ b/js/src/builtin/Object.cpp
@@ -1450,17 +1450,17 @@ static bool
 TryEnumerableOwnPropertiesUnboxed(JSContext* cx, HandleObject obj, MutableHandleValue rval,
                                   bool* optimized)
 {
     *optimized = false;
 
     if (!obj->is<UnboxedPlainObject>())
         return true;
 
-    UnboxedPlainObject* uobj = &obj->as<UnboxedPlainObject>();
+    Handle<UnboxedPlainObject*> uobj = obj.as<UnboxedPlainObject>();
     if (uobj->maybeExpando())
         return true;
 
     *optimized = true;
 
     AutoValueVector properties(cx);
     RootedValue key(cx);
     RootedValue value(cx);