Bug 1512274 - [geckoview] Make all constants actually final. r=geckoview-reviewers,snorp
☠☠ backed out by 1f911d12fd07 ☠ ☠
authorAgi Sferro <agi@mozilla.com>
Fri, 15 Mar 2019 18:08:40 +0000
changeset 522087 5d02f27fe1747a473a400e8473dc3acf0a365ea1
parent 522086 380cdbe5557c86bed91f985824cee75321ee282c
child 522088 60897ab005748ea3b73825e6502518b6ab3684d7
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgeckoview-reviewers, snorp
bugs1512274
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1512274 - [geckoview] Make all constants actually final. r=geckoview-reviewers,snorp Depends on D23684 Differential Revision: https://phabricator.services.mozilla.com/D23685
mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/MediaManager.java
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java
--- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/MediaManager.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/MediaManager.java
@@ -10,17 +10,17 @@ import android.os.Binder;
 import android.os.IBinder;
 import android.os.Process;
 import android.os.RemoteException;
 import android.util.Log;
 
 import org.mozilla.gecko.mozglue.GeckoLoader;
 
 public final class MediaManager extends Service {
-    private static String LOGTAG = "GeckoMediaManager";
+    private static final String LOGTAG = "GeckoMediaManager";
     private static boolean sNativeLibLoaded;
 
     private Binder mBinder = new IMediaManager.Stub() {
         @Override
         public ICodec createCodec() throws RemoteException {
             return new Codec();
         }
 
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntimeSettings.java
@@ -656,17 +656,17 @@ public final class GeckoRuntimeSettings 
      * Gets the current video autoplay mode.
      * @return The current video autoplay mode. Will be either {@link GeckoRuntimeSettings#AUTOPLAY_DEFAULT_ALLOWED}
      * or {@link GeckoRuntimeSettings#AUTOPLAY_DEFAULT_BLOCKED}
      */
     public @AutoplayDefault int getAutoplayDefault() {
         return mAutoplayDefault.get();
     }
 
-    private static int FONT_INFLATION_BASE_VALUE = 120;
+    private static final int FONT_INFLATION_BASE_VALUE = 120;
 
     /**
      * Set a font size factor that will operate as a global text zoom. All font sizes will be
      * multiplied by this factor.
      *
      * <p>The default factor is 1.0.
      *
      * <p>Currently, any changes only take effect after a reload of the session.