Bug 1507540 part 4. Remove unused nsIProfiler::GetStartParams. r=mconley
authorBoris Zbarsky <bzbarsky@mit.edu>
Mon, 19 Nov 2018 20:17:53 -0500
changeset 503590 5cdbce9b4a51adadd43a80440cc451cf4b9b85a5
parent 503589 52d07c32fa7c1f4114be113fc857484ed20a1630
child 503591 f50e3a884aa8bfc672952a93cbafe02f376292bd
push id10290
push userffxbld-merge
push dateMon, 03 Dec 2018 16:23:23 +0000
treeherdermozilla-beta@700bed2445e6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1507540
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1507540 part 4. Remove unused nsIProfiler::GetStartParams. r=mconley
tools/profiler/gecko/nsIProfiler.idl
tools/profiler/gecko/nsProfiler.cpp
--- a/tools/profiler/gecko/nsIProfiler.idl
+++ b/tools/profiler/gecko/nsIProfiler.idl
@@ -77,22 +77,16 @@ interface nsIProfiler : nsISupports
   void GetFeatures(out uint32_t aCount, [retval, array, size_is(aCount)] out string aFeatures);
 
   /**
    * Returns an array of all features that are supported by the profiler.
    * The array may contain features that are not supported in this build.
    */
   void GetAllFeatures(out uint32_t aCount, [retval, array, size_is(aCount)] out string aFeatures);
 
-  /**
-   * The starting parameters that were sent to the profiler for sampling.
-   * If the profiler is not currently sampling, this will return null.
-   */
-  [noscript] readonly attribute nsIProfilerStartParams startParams;
-
   void GetBufferInfo(out uint32_t aCurrentPosition, out uint32_t aTotalSize,
                      out uint32_t aGeneration);
 
   /**
    * Returns the elapsed time, in milliseconds, since the profiler's epoch.
    * The epoch is guaranteed to be constant for the duration of the
    * process, but is otherwise arbitrary.
    */
--- a/tools/profiler/gecko/nsProfiler.cpp
+++ b/tools/profiler/gecko/nsProfiler.cpp
@@ -533,41 +533,16 @@ nsProfiler::GetFeatures(uint32_t* aCount
 NS_IMETHODIMP
 nsProfiler::GetAllFeatures(uint32_t* aCount, char*** aFeatureList)
 {
   GetArrayOfStringsForFeatures((uint32_t)-1, aCount, aFeatureList);
   return NS_OK;
 }
 
 NS_IMETHODIMP
-nsProfiler::GetStartParams(nsIProfilerStartParams** aRetVal)
-{
-  if (!profiler_is_active()) {
-    *aRetVal = nullptr;
-  } else {
-    int entries = 0;
-    double interval = 0;
-    uint32_t features = 0;
-    mozilla::Vector<const char*> filters;
-    profiler_get_start_params(&entries, &interval, &features, &filters);
-
-    nsTArray<nsCString> filtersArray;
-    for (uint32_t i = 0; i < filters.length(); ++i) {
-      filtersArray.AppendElement(filters[i]);
-    }
-
-    nsCOMPtr<nsIProfilerStartParams> startParams =
-      new nsProfilerStartParams(entries, interval, features, filtersArray);
-
-    startParams.forget(aRetVal);
-  }
-  return NS_OK;
-}
-
-NS_IMETHODIMP
 nsProfiler::GetBufferInfo(uint32_t* aCurrentPosition, uint32_t* aTotalSize,
                           uint32_t* aGeneration)
 {
   MOZ_ASSERT(aCurrentPosition);
   MOZ_ASSERT(aTotalSize);
   MOZ_ASSERT(aGeneration);
   Maybe<ProfilerBufferInfo> info = profiler_get_buffer_info();
   if (info) {