Bug 854924 - Change "can't allocate graphics resources" in TabParent to an NS_WARNING. r=bent
authorJustin Lebar <justin.lebar@gmail.com>
Thu, 28 Mar 2013 14:25:58 -0400
changeset 137007 5c230db2b247f420378825191366b92bbcfaec1f
parent 137006 f1b0e51c1b929ff2cd909e5bed3dccc9ac4f29b2
child 137008 3e18a5b5257d321b229cf0a64fab9957db10a0fc
push id2452
push userlsblakk@mozilla.com
push dateMon, 13 May 2013 16:59:38 +0000
treeherdermozilla-beta@d4b152d29d8d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbent
bugs854924
milestone22.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 854924 - Change "can't allocate graphics resources" in TabParent to an NS_WARNING. r=bent We hit this assertion during our tests, which sometimes complete before the subprocess is Show()'n. This isn't a bug, as far as I can tell. Changing the NS_ERROR to NS_WARNING keeps us from failing on tryserver.
dom/ipc/TabParent.cpp
--- a/dom/ipc/TabParent.cpp
+++ b/dom/ipc/TabParent.cpp
@@ -1270,17 +1270,17 @@ TabParent::AllocPRenderFrame(ScrollingBe
                              LayersBackend* aBackend,
                              int32_t* aMaxTextureSize,
                              uint64_t* aLayersId)
 {
   MOZ_ASSERT(ManagedPRenderFrameParent().IsEmpty());
 
   nsRefPtr<nsFrameLoader> frameLoader = GetFrameLoader();
   if (!frameLoader) {
-    NS_ERROR("Can't allocate graphics resources, aborting subprocess");
+    NS_WARNING("Can't allocate graphics resources, aborting subprocess");
     return nullptr;
   }
 
   *aScrolling = UseAsyncPanZoom() ? ASYNC_PAN_ZOOM : DEFAULT_SCROLLING;
   return new RenderFrameParent(frameLoader,
                                *aScrolling,
                                aBackend, aMaxTextureSize, aLayersId);
 }