Bug 974710 - Stop incorrectly reporting errors with values attribute on the animateMotion element. r=dholbert
☠☠ backed out by fea151789006 ☠ ☠
authorRobert Longson <longsonr@gmail.com>
Wed, 16 Apr 2014 10:43:36 +0100
changeset 197303 5bb0b8d757f4f7cb2571ece0c342c2ba7070da11
parent 197302 a668d68c3592a14581b69bea1433b1680da38c7f
child 197304 fea1517890061a66ea5b73f5c053e086497b65e3
push id3624
push userasasaki@mozilla.com
push dateMon, 09 Jun 2014 21:49:01 +0000
treeherdermozilla-beta@b1a5da15899a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs974710
milestone31.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 974710 - Stop incorrectly reporting errors with values attribute on the animateMotion element. r=dholbert
content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
--- a/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
+++ b/content/svg/content/src/SVGMotionSMILAnimationFunction.cpp
@@ -67,25 +67,28 @@ SVGMotionSMILAnimationFunction::SetAttr(
     }
   } else if (aAttribute == nsGkAtoms::rotate) {
     nsresult rv = SetRotate(aValue, aResult);
     if (aParseResult) {
       *aParseResult = rv;
     }
   } else if (aAttribute == nsGkAtoms::path) {
     aResult.SetTo(aValue);
+    MarkStaleIfAttributeAffectsPath(aAttribute);
     if (aParseResult) {
       *aParseResult = NS_OK;
     }
-    MarkStaleIfAttributeAffectsPath(aAttribute);
   } else if (aAttribute == nsGkAtoms::by ||
              aAttribute == nsGkAtoms::from ||
              aAttribute == nsGkAtoms::to ||
              aAttribute == nsGkAtoms::values) {
     MarkStaleIfAttributeAffectsPath(aAttribute);
+    if (aParseResult) {
+      *aParseResult = NS_OK;
+    }
   } else {
     // Defer to superclass method
     return nsSMILAnimationFunction::SetAttr(aAttribute, aValue,
                                             aResult, aParseResult);
   }
 
   return true;
 }