Address review comments from bug 1246804
authorSteve Fink <sfink@mozilla.com>
Tue, 15 Mar 2016 14:22:13 -0700
changeset 326838 5b9b5716a55daef9d627de718fe3fa32a09643ca
parent 326837 a571bba8cecdbddc45426f700c3a19e9de230261
child 326839 0e845c982897050f35fdd9c40a52a72ce3c1691c
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1246804
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Address review comments from bug 1246804
js/src/devtools/rootAnalysis/computeCallgraph.js
js/src/devtools/rootAnalysis/computeGCTypes.js
js/src/devtools/rootAnalysis/run-test.py
js/src/tests/jstests.py
--- a/js/src/devtools/rootAnalysis/computeCallgraph.js
+++ b/js/src/devtools/rootAnalysis/computeCallgraph.js
@@ -213,22 +213,19 @@ function getAnnotations(body)
     }
 
     return all_annotations;
 }
 
 function getTags(functionName, body) {
     var tags = new Set();
     var annotations = getAnnotations(body);
-    print(functionName);
-    print(JSON.stringify(annotations));
     if (functionName in annotations) {
         print("crawling through");
         for (var [ annName, annValue ] of annotations[functionName]) {
-            print(`  got ${annName}: ${annValue}`);
             if (annName == 'Tag')
                 tags.add(annValue);
         }
     }
     return tags;
 }
 
 function processBody(functionName, body)
--- a/js/src/devtools/rootAnalysis/computeGCTypes.js
+++ b/js/src/devtools/rootAnalysis/computeGCTypes.js
@@ -202,18 +202,18 @@ function addGCType(typeName, child, why,
     markGCType(typeName, '<annotation>', '(annotation)', 0, 0, "");
 }
 
 function addGCPointer(typeName)
 {
     markGCType(typeName, '<pointer-annotation>', '(annotation)', 1, 0, "");
 }
 
-//for (var type of listNonGCPointers())
-//    annotations.NonGCPointers[type] = true;
+for (var type of listNonGCPointers())
+    annotations.NonGCPointers[type] = true;
 
 function explain(csu, indent, seen) {
     if (!seen)
         seen = new Set();
     seen.add(csu);
     if (!gcFields.has(csu))
         return;
     var fields = gcFields.get(csu);
--- a/js/src/devtools/rootAnalysis/run-test.py
+++ b/js/src/devtools/rootAnalysis/run-test.py
@@ -1,8 +1,13 @@
+#!/usr/bin/env python
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
 import sys
 import os
 import re
 import json
 import subprocess
 
 testdir = os.path.abspath(os.path.dirname(__file__))
 
--- a/js/src/tests/jstests.py
+++ b/js/src/tests/jstests.py
@@ -1,9 +1,13 @@
 #!/usr/bin/env python
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
 """
 The JS Shell Test Harness.
 
 See the adjacent README.txt for more details.
 """
 
 from __future__ import print_function