bug 1392603 - Remove toolkit/crashreporter/tools/win32. r=gsvelto
authorTed Mielczarek <ted@mielczarek.org>
Fri, 04 Jan 2019 13:39:39 +0000
changeset 509821 5b395d1d3585f20579c098cd000adfe26eb84831
parent 509820 b9a24fd4b40bc79930265fb09c4fbe2656b9a6f3
child 509822 1ae462ea62d760a6a36e7709dd2b1cd748da7b14
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgsvelto
bugs1392603
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1392603 - Remove toolkit/crashreporter/tools/win32. r=gsvelto We have prebuilt dump_syms binaries in toolkit/crashreporter/tools/win32 from the days when we didn't build it as part of the build. There's one per MSVC version, since the APIs it uses are version-specific, but we don't actually support building with the MSVC versions corresponding to the binaries in that directory anymore, so we should just remove them. The only code change necessary here is changing the functional test to skip running the test if a dump_syms binary isn't available. MozReview-Commit-ID: IBuJZMVfv7C Differential Revision: https://phabricator.services.mozilla.com/D15717
toolkit/crashreporter/tools/unit-symbolstore.py
toolkit/crashreporter/tools/win32/dump_syms_vc1600.exe
toolkit/crashreporter/tools/win32/dump_syms_vc1700.exe
toolkit/crashreporter/tools/win32/dump_syms_vc1800.exe
--- a/toolkit/crashreporter/tools/unit-symbolstore.py
+++ b/toolkit/crashreporter/tools/unit-symbolstore.py
@@ -474,22 +474,17 @@ class TestFunctional(HelperMixin, unitte
                                         'crashreporter', 'tools',
                                         'symbolstore.py')
         if target_platform() == 'WINNT':
             if buildconfig.substs['MSVC_HAS_DIA_SDK']:
                 self.dump_syms = os.path.join(buildconfig.topobjdir,
                                               'dist', 'host', 'bin',
                                               'dump_syms.exe')
             else:
-                self.dump_syms = os.path.join(self.topsrcdir,
-                                              'toolkit',
-                                              'crashreporter',
-                                              'tools',
-                                              'win32',
-                                              'dump_syms_vc{_MSC_VER}.exe'.format(**buildconfig.substs))
+                self.skip_test = True
             self.target_bin = os.path.join(buildconfig.topobjdir,
                                            'dist', 'bin',
                                            'firefox.exe')
         else:
             self.dump_syms = os.path.join(buildconfig.topobjdir,
                                           'dist', 'host', 'bin',
                                           'dump_syms')
             self.target_bin = os.path.join(buildconfig.topobjdir,
deleted file mode 100755
index 489cc4c4ade41cd5e1b31a1ea3cd92876a011878..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 0ead28957e60c6653c124ddb6a8c4759f47c1339..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001
deleted file mode 100644
index 22e7398abdd2ff737541a4e50121c5872522a4bb..e69de29bb2d1d6434b8b29ae775ad8c2e48c5391
GIT binary patch
literal 0
Hc$@<O00001