Bug 1078226 Unexpected Audio Level indicator on audio-only calls for Loop, also disable broken low-quality video warning indicator. r=nperriault a=lmandel
authorMark Banner <standard8@mozilla.com>
Wed, 15 Oct 2014 13:25:56 +0100
changeset 225732 5ad9f4e96214
parent 225731 880cfb4ef6f8
child 225733 f705ffd06218
push id3995
push userrjesup@wgate.com
push date2014-10-20 00:58 +0000
treeherdermozilla-beta@8c42ccaf8aa1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnperriault, lmandel
bugs1078226
milestone34.0
Bug 1078226 Unexpected Audio Level indicator on audio-only calls for Loop, also disable broken low-quality video warning indicator. r=nperriault a=lmandel
browser/components/loop/content/js/conversationViews.js
browser/components/loop/content/js/conversationViews.jsx
browser/components/loop/content/shared/js/views.js
browser/components/loop/content/shared/js/views.jsx
--- a/browser/components/loop/content/js/conversationViews.js
+++ b/browser/components/loop/content/js/conversationViews.js
@@ -279,19 +279,21 @@ loop.conversationViews = (function(mozL1
       // height set to 100%" to fix video layout on Google Chrome
       // @see https://bugzilla.mozilla.org/show_bug.cgi?id=1020445
       return {
         insertMode: "append",
         width: "100%",
         height: "100%",
         publishVideo: this.props.video.enabled,
         style: {
+          audioLevelDisplayMode: "off",
           bugDisplayMode: "off",
           buttonDisplayMode: "off",
-          nameDisplayMode: "off"
+          nameDisplayMode: "off",
+          videoDisabledDisplayMode: "off"
         }
       }
     },
 
     /**
      * Used to update the video container whenever the orientation or size of the
      * display area changes.
      */
--- a/browser/components/loop/content/js/conversationViews.jsx
+++ b/browser/components/loop/content/js/conversationViews.jsx
@@ -279,19 +279,21 @@ loop.conversationViews = (function(mozL1
       // height set to 100%" to fix video layout on Google Chrome
       // @see https://bugzilla.mozilla.org/show_bug.cgi?id=1020445
       return {
         insertMode: "append",
         width: "100%",
         height: "100%",
         publishVideo: this.props.video.enabled,
         style: {
+          audioLevelDisplayMode: "off",
           bugDisplayMode: "off",
           buttonDisplayMode: "off",
-          nameDisplayMode: "off"
+          nameDisplayMode: "off",
+          videoDisabledDisplayMode: "off"
         }
       }
     },
 
     /**
      * Used to update the video container whenever the orientation or size of the
      * display area changes.
      */
--- a/browser/components/loop/content/shared/js/views.js
+++ b/browser/components/loop/content/shared/js/views.js
@@ -146,19 +146,21 @@ loop.shared.views = (function(_, OT, l10
 
     // height set to 100%" to fix video layout on Google Chrome
     // @see https://bugzilla.mozilla.org/show_bug.cgi?id=1020445
     publisherConfig: {
       insertMode: "append",
       width: "100%",
       height: "100%",
       style: {
+        audioLevelDisplayMode: "off",
         bugDisplayMode: "off",
         buttonDisplayMode: "off",
-        nameDisplayMode: "off"
+        nameDisplayMode: "off",
+        videoDisabledDisplayMode: "off"
       }
     },
 
     getDefaultProps: function() {
       return {
         initiate: true,
         video: {enabled: true, visible: true},
         audio: {enabled: true, visible: true}
--- a/browser/components/loop/content/shared/js/views.jsx
+++ b/browser/components/loop/content/shared/js/views.jsx
@@ -146,19 +146,21 @@ loop.shared.views = (function(_, OT, l10
 
     // height set to 100%" to fix video layout on Google Chrome
     // @see https://bugzilla.mozilla.org/show_bug.cgi?id=1020445
     publisherConfig: {
       insertMode: "append",
       width: "100%",
       height: "100%",
       style: {
+        audioLevelDisplayMode: "off",
         bugDisplayMode: "off",
         buttonDisplayMode: "off",
-        nameDisplayMode: "off"
+        nameDisplayMode: "off",
+        videoDisabledDisplayMode: "off"
       }
     },
 
     getDefaultProps: function() {
       return {
         initiate: true,
         video: {enabled: true, visible: true},
         audio: {enabled: true, visible: true}