Bug 1381137: Append skipped/dropped message to Stylo CSS error reports. r=heycam
authorJosh Matthews <josh@joshmatthews.net>
Wed, 26 Jul 2017 14:54:25 +0200
changeset 419791 5a8e2014949047ed5daf62f2636ef3e0ab3dda38
parent 419790 e6bf9d2afc7d0cd3f7dc35fcdfeeec5e22d27ef9
child 419792 e3dadcaf272679963974179a1334f8c2df1ef57f
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersheycam
bugs1381137
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1381137: Append skipped/dropped message to Stylo CSS error reports. r=heycam MozReview-Commit-ID: GUgJneVg1oy
layout/style/ServoBindings.cpp
layout/style/ServoBindings.h
--- a/layout/style/ServoBindings.cpp
+++ b/layout/style/ServoBindings.cpp
@@ -2741,18 +2741,22 @@ void
 Gecko_ReportUnexpectedCSSError(ErrorReporter* reporter,
                                const char* message,
                                const char* param,
                                uint32_t paramLen,
                                const char* source,
                                uint32_t sourceLen,
                                uint32_t lineNumber,
                                uint32_t colNumber,
-                               nsIURI* uri)
+                               nsIURI* uri,
+                               const char* followup)
 {
   MOZ_ASSERT(NS_IsMainThread());
 
   nsDependentCSubstring paramValue(param, paramLen);
   nsAutoString wideParam = NS_ConvertUTF8toUTF16(paramValue);
   reporter->ReportUnexpectedUnescaped(message, wideParam);
+  if (followup) {
+    reporter->ReportUnexpected(followup);
+  }
   nsDependentCSubstring sourceValue(source, sourceLen);
   reporter->OutputError(lineNumber, colNumber, sourceValue);
 }
--- a/layout/style/ServoBindings.h
+++ b/layout/style/ServoBindings.h
@@ -682,13 +682,14 @@ void Gecko_DestroyCSSErrorReporter(mozil
 void Gecko_ReportUnexpectedCSSError(mozilla::css::ErrorReporter* reporter,
                                     const char* message,
                                     const char* param,
                                     uint32_t paramLen,
                                     const char* source,
                                     uint32_t sourceLen,
                                     uint32_t lineNumber,
                                     uint32_t colNumber,
-                                    nsIURI* aURI);
+                                    nsIURI* aURI,
+                                    const char* followup);
 
 } // extern "C"
 
 #endif // mozilla_ServoBindings_h