Bug 1550540: Don't call Close() in PC's d'tor. r=mjf
authorByron Campen [:bwc] <docfaraday@gmail.com>
Fri, 10 May 2019 02:49:17 +0000
changeset 532500 59841dabe8e1abd284a7e3b14d98e69861c0e2a2
parent 532499 5a993bd3862b7a5b40771c25d962ba9c30ce76de
child 532501 4fbfc8798cad0ecc7ae867ed943b91b24789a500
push id11268
push usercsabou@mozilla.com
push dateTue, 14 May 2019 15:24:22 +0000
treeherdermozilla-beta@5fb7fcd568d6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmjf
bugs1550540
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550540: Don't call Close() in PC's d'tor. r=mjf Differential Revision: https://phabricator.services.mozilla.com/D30555
media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
--- a/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
+++ b/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
@@ -359,18 +359,16 @@ PeerConnectionImpl::~PeerConnectionImpl(
     PeerConnectionCtx::GetInstance()->mPeerConnections.erase(mHandle);
   } else {
     CSFLogError(LOGTAG, "PeerConnectionCtx is already gone. Ignoring...");
   }
 
   CSFLogInfo(LOGTAG, "%s: PeerConnectionImpl destructor invoked for %s",
              __FUNCTION__, mHandle.c_str());
 
-  Close();
-
   // Since this and Initialize() occur on MainThread, they can't both be
   // running at once
 
   // Right now, we delete PeerConnectionCtx at XPCOM shutdown only, but we
   // probably want to shut it down more aggressively to save memory.  We
   // could shut down here when there are no uses.  It might be more optimal
   // to release off a timer (and XPCOM Shutdown) to avoid churn
 }