Bug 1429904 - Let the compiler implement the FrameKey copy constructor for us. r=njn
☠☠ backed out by bf5a8698216c ☠ ☠
authorMarkus Stange <mstange@themasta.com>
Tue, 27 Feb 2018 23:08:19 -0500
changeset 458295 595906406c168abe0276e68c5681ab67bad2268b
parent 458294 39a1b2434439f995c2d257aa89840a4418a8ca61
child 458296 377750a82bf656a9773ea99e3edc9a70606bb48e
push id8808
push userarchaeopteryx@coole-files.de
push dateFri, 02 Mar 2018 22:13:05 +0000
treeherdermozilla-beta@7475508d19db [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnjn
bugs1429904
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1429904 - Let the compiler implement the FrameKey copy constructor for us. r=njn MozReview-Commit-ID: 9e9rMkEAyeL
tools/profiler/core/ProfileBufferEntry.h
--- a/tools/profiler/core/ProfileBufferEntry.h
+++ b/tools/profiler/core/ProfileBufferEntry.h
@@ -178,31 +178,24 @@ public:
     mozilla::Maybe<JITAddress> mJITAddress;
     mozilla::Maybe<uint32_t> mJITDepth;
 
     explicit FrameKey(const char* aLocation)
      : mLocation(aLocation)
     {
     }
 
-    FrameKey(const FrameKey& aToCopy)
-     : mLocation(aToCopy.mLocation)
-     , mLine(aToCopy.mLine)
-     , mCategory(aToCopy.mCategory)
-     , mJITAddress(aToCopy.mJITAddress)
-     , mJITDepth(aToCopy.mJITDepth)
-    {
-    }
-
     FrameKey(const JITAddress& aJITAddress, uint32_t aJITDepth)
      : mJITAddress(mozilla::Some(aJITAddress))
      , mJITDepth(mozilla::Some(aJITDepth))
     {
     }
 
+    FrameKey(const FrameKey& aToCopy) = default;
+
     uint32_t Hash() const;
     bool operator==(const FrameKey& aOther) const;
   };
 
   struct StackKey {
     mozilla::Maybe<uint32_t> mPrefixStackIndex;
     uint32_t mFrameIndex;