Bug 1476779. Remove expired IMAGE_ANIMATED_* telemetry. r=aosmond
authorTimothy Nikkel <tnikkel@gmail.com>
Mon, 06 Aug 2018 22:40:31 -0500
changeset 485395 58968b3702fd25b217a4eddf6d3348df8c1fcbc0
parent 485394 9b0307cc517369c9f93278a75e24b73c6390d36e
child 485396 e6764dc173956fa095d06dad0ba8961e004d5319
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersaosmond
bugs1476779, 686905
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1476779. Remove expired IMAGE_ANIMATED_* telemetry. r=aosmond It was added to monitor the impact of bug 686905. Which went as expected, no spikes or alerts since then. So no need to keep it.
image/RasterImage.cpp
toolkit/components/telemetry/Histograms.json
--- a/image/RasterImage.cpp
+++ b/image/RasterImage.cpp
@@ -102,19 +102,16 @@ RasterImage::~RasterImage()
     mSourceBuffer->Complete(NS_ERROR_ABORT);
   }
 
   // Release all frames from the surface cache.
   SurfaceCache::RemoveImage(ImageKey(this));
 
   // Record Telemetry.
   Telemetry::Accumulate(Telemetry::IMAGE_DECODE_COUNT, mDecodeCount);
-  if (mAnimationState) {
-    Telemetry::Accumulate(Telemetry::IMAGE_ANIMATED_DECODE_COUNT, mDecodeCount);
-  }
 }
 
 nsresult
 RasterImage::Init(const char* aMimeType,
                   uint32_t aFlags)
 {
   // We don't support re-initialization
   if (mInitialized) {
@@ -1507,21 +1504,16 @@ RasterImage::Draw(gfxContext* aContext,
 
   auto drawResult = DrawInternal(std::move(result.Surface()), aContext, aSize,
                                  aRegion, aSamplingFilter, flags, aOpacity);
 
   if (shouldRecordTelemetry) {
       TimeDuration drawLatency = TimeStamp::Now() - mDrawStartTime;
       Telemetry::Accumulate(Telemetry::IMAGE_DECODE_ON_DRAW_LATENCY,
                             int32_t(drawLatency.ToMicroseconds()));
-      if (mAnimationState) {
-        Telemetry::Accumulate(Telemetry::IMAGE_ANIMATED_DECODE_ON_DRAW_LATENCY,
-                              int32_t(drawLatency.ToMicroseconds()));
-
-      }
       mDrawStartTime = TimeStamp();
   }
 
   return drawResult;
 }
 
 //******************************************************************************
 
@@ -1766,21 +1758,16 @@ RasterImage::NotifyDecodeComplete(const 
     if (aTelemetry.mChunkCount) {
       Telemetry::Accumulate(Telemetry::IMAGE_DECODE_CHUNKS, aTelemetry.mChunkCount);
     }
 
     if (aStatus.mFinished) {
       Telemetry::Accumulate(Telemetry::IMAGE_DECODE_TIME,
                             int32_t(aTelemetry.mDecodeTime.ToMicroseconds()));
 
-      if (mAnimationState) {
-        Telemetry::Accumulate(Telemetry::IMAGE_ANIMATED_DECODE_TIME,
-                              int32_t(aTelemetry.mDecodeTime.ToMicroseconds()));
-      }
-
       if (aTelemetry.mSpeedHistogram && aTelemetry.mBytesDecoded) {
         Telemetry::Accumulate(*aTelemetry.mSpeedHistogram, aTelemetry.Speed());
       }
     }
   }
 
   // Only act on errors if we have no usable frames from the decoder.
   if (aStatus.mHadError &&
--- a/toolkit/components/telemetry/Histograms.json
+++ b/toolkit/components/telemetry/Histograms.json
@@ -1231,48 +1231,26 @@
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
     "expires_in_version": "never",
     "kind": "exponential",
     "low": 50,
     "high": 50000000,
     "n_buckets": 100,
     "description": "Time spent decoding an image (us)"
   },
-  "IMAGE_ANIMATED_DECODE_TIME": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
-    "bug_numbers": [1347302],
-    "expires_in_version": "57",
-    "kind": "exponential",
-    "low": 50,
-    "high": 50000000,
-    "n_buckets": 100,
-    "description": "Time spent decoding an animated image (us)"
-  },
   "IMAGE_DECODE_ON_DRAW_LATENCY": {
     "record_in_processes": ["main", "content"],
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
     "expires_in_version": "never",
     "kind": "exponential",
     "low": 50,
     "high": 50000000,
     "n_buckets": 100,
     "description": "Time from starting a decode to it showing up on the screen (us)"
   },
-  "IMAGE_ANIMATED_DECODE_ON_DRAW_LATENCY": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
-    "bug_numbers": [1347302],
-    "expires_in_version": "57",
-    "kind": "exponential",
-    "low": 50,
-    "high": 50000000,
-    "n_buckets": 100,
-    "description": "Time from starting a decode of an animated image to it showing up on the screen (us)"
-  },
   "IMAGE_DECODE_CHUNKS": {
     "record_in_processes": ["main", "content"],
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
     "expires_in_version": "never",
     "kind": "exponential",
     "high": 500,
     "n_buckets": 50,
     "description": "Number of chunks per decode attempt"
@@ -1281,26 +1259,16 @@
     "record_in_processes": ["main", "content"],
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
     "expires_in_version": "never",
     "kind": "exponential",
     "high": 500,
     "n_buckets": 50,
     "description": "Decode count"
   },
-  "IMAGE_ANIMATED_DECODE_COUNT": {
-    "record_in_processes": ["main", "content"],
-    "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
-    "bug_numbers": [1347302],
-    "expires_in_version": "57",
-    "kind": "exponential",
-    "high": 500,
-    "n_buckets": 50,
-    "description": "Decode count of animated images"
-  },
   "IMAGE_DECODE_SPEED_JPEG": {
     "record_in_processes": ["main", "content"],
     "alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
     "expires_in_version": "never",
     "kind": "exponential",
     "low": 500,
     "high": 50000000,
     "n_buckets": 50,