Bug 1312216 - Changed delete this._openedURL and set it as null instead. There was a strict warning. r=Gijs
authorAlan Xu <ayx002@ucsd.edu>
Tue, 17 Jan 2017 16:52:47 -0800
changeset 374985 580064ea1d81e8764f36eb1ce7ff0176f247d2a1
parent 374984 5acfb0d242bf67957c52fbef3b9135ba0f4720d4
child 374986 abb7ae94f6ec9fadb43f81637cddab9d762587aa
push id6996
push userjlorenzo@mozilla.com
push dateMon, 06 Mar 2017 20:48:21 +0000
treeherdermozilla-beta@d89512dab048 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs
bugs1312216
milestone53.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1312216 - Changed delete this._openedURL and set it as null instead. There was a strict warning. r=Gijs MozReview-Commit-ID: 3s3cojJVXcE
browser/components/preferences/in-content/subdialogs.js
--- a/browser/components/preferences/in-content/subdialogs.js
+++ b/browser/components/preferences/in-content/subdialogs.js
@@ -107,17 +107,17 @@ var gSubDialog = {
 
     setTimeout(() => {
       // Unload the dialog after the event listeners run so that the load of about:blank isn't
       // cancelled by the ESC <key>.
       let onBlankLoad = e => {
         if (this._frame.contentWindow.location.href == "about:blank") {
           this._frame.removeEventListener("load", onBlankLoad);
           // We're now officially done closing, so update the state to reflect that.
-          delete this._openedURL;
+          this._openedURL = null;
           this._isClosing = false;
           this._resolveClosePromise();
         }
       };
       this._frame.addEventListener("load", onBlankLoad);
       this._frame.loadURI("about:blank");
     }, 0);
   },