Bug 1533691 - Uncommented the code and removed TODO comment. r=mak
authorjawad <ijawadak@gmail.com>
Mon, 11 Mar 2019 09:59:19 +0000
changeset 521328 57f4edb121f34398501c059a98d499ed1c4f5817
parent 521327 3a421f33761b6b852b6b18ee61fb8dc33f8e0d7f
child 521329 7b2ae2ea04957e8f18250ffc62563f301e5335f8
push id10866
push usernerli@mozilla.com
push dateTue, 12 Mar 2019 18:59:09 +0000
treeherdermozilla-beta@445c24a51727 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmak
bugs1533691
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1533691 - Uncommented the code and removed TODO comment. r=mak Differential Revision: https://phabricator.services.mozilla.com/D22871
browser/components/urlbar/UrlbarInput.jsm
--- a/browser/components/urlbar/UrlbarInput.jsm
+++ b/browser/components/urlbar/UrlbarInput.jsm
@@ -916,19 +916,18 @@ class UrlbarInput {
     } catch (ex) {
       // This load can throw an exception in certain cases, which means
       // we'll want to replace the URL with the loaded URL:
       if (ex.result != Cr.NS_ERROR_LOAD_SHOWED_ERRORPAGE) {
         this.handleRevert();
       }
     }
 
-    // TODO This should probably be handed via input.
     // Ensure the start of the URL is visible for usability reasons.
-    // this.selectionStart = this.selectionEnd = 0;
+    this.selectionStart = this.selectionEnd = 0;
 
     this.closePopup();
   }
 
   /**
    * Determines where a URL/page should be opened.
    *
    * @param {Event} event the event triggering the opening.