Bug 1176073 - Missing mIPCClosed check in SendReportSecurityMessage. r=honza, a=ritu
authorJason Duell <jduell.mcbugs@gmail.com>
Tue, 14 Jul 2015 15:03:00 +0200
changeset 281772 57e339c192c615738f605f1124badd898f532035
parent 281771 329cce06a9a864c6239954e28ff33c85c998aeb2
child 281773 835bf8618bc4f006ba383fa87c1ab9c8e2d046e7
push id4932
push userjlund@mozilla.com
push dateMon, 10 Aug 2015 18:23:06 +0000
treeherdermozilla-beta@6dd5a4f5f745 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewershonza, ritu
bugs1176073
milestone41.0a2
Bug 1176073 - Missing mIPCClosed check in SendReportSecurityMessage. r=honza, a=ritu
netwerk/protocol/http/HttpChannelParent.cpp
--- a/netwerk/protocol/http/HttpChannelParent.cpp
+++ b/netwerk/protocol/http/HttpChannelParent.cpp
@@ -1309,16 +1309,17 @@ HttpChannelParent::GetAuthPrompt(uint32_
 //-----------------------------------------------------------------------------
 // HttpChannelSecurityWarningReporter
 //-----------------------------------------------------------------------------
 
 nsresult
 HttpChannelParent::ReportSecurityMessage(const nsAString& aMessageTag,
                                          const nsAString& aMessageCategory)
 {
-  if (NS_WARN_IF(!SendReportSecurityMessage(nsString(aMessageTag),
+  if (mIPCClosed ||
+      NS_WARN_IF(!SendReportSecurityMessage(nsString(aMessageTag),
                                             nsString(aMessageCategory)))) {
     return NS_ERROR_UNEXPECTED;
   }
   return NS_OK;
 }
 
 }} // mozilla::net