Backed out changeset 2ab35272d8c4 (bug 1643700) for bustages on regexp-bytecodes.cc . CLOSED TREE
authorNarcis Beleuzu <nbeleuzu@mozilla.com>
Fri, 05 Jun 2020 18:30:20 +0300
changeset 598237 56cc12211adf546d4fdb7505399b62a1b33f7361
parent 598236 a63a27cde0b2dd0b7c17ec31de946d4c35e17463
child 598238 041cd14e38935afd3d72c6b72c46494bcd61abe8
push id13310
push userffxbld-merge
push dateMon, 29 Jun 2020 14:50:06 +0000
treeherdermozilla-beta@15a59a0afa5c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1643700
milestone79.0a1
backs out2ab35272d8c449c2437c0daa1651965770f9222d
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 2ab35272d8c4 (bug 1643700) for bustages on regexp-bytecodes.cc . CLOSED TREE
js/src/irregexp/imported/regexp-bytecode-peephole.cc
js/src/irregexp/moz.build
--- a/js/src/irregexp/imported/regexp-bytecode-peephole.cc
+++ b/js/src/irregexp/imported/regexp-bytecode-peephole.cc
@@ -240,17 +240,17 @@ class RegExpBytecodePeephole {
 
   Zone* zone_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(RegExpBytecodePeephole);
 };
 
 template <typename T>
 T GetValue(const byte* buffer, int pos) {
-  DCHECK(IsAligned(reinterpret_cast<Address>(buffer + pos), alignof(T)));
+  DCHECK(IsAligned(reinterpret_cast<v8::Address>(buffer + pos), alignof(T)));
   return *reinterpret_cast<const T*>(buffer + pos);
 }
 
 int32_t GetArgumentValue(const byte* bytecode, int offset, int length) {
   switch (length) {
     case 1:
       return GetValue<byte>(bytecode, offset);
       break;
--- a/js/src/irregexp/moz.build
+++ b/js/src/irregexp/moz.build
@@ -24,22 +24,20 @@ UNIFIED_SOURCES += [
     'imported/regexp-compiler.cc',
     'imported/regexp-dotprinter.cc',
     'imported/regexp-interpreter.cc',
     'imported/regexp-macro-assembler-tracer.cc',
     'imported/regexp-macro-assembler.cc',
     'imported/regexp-parser.cc',
     'imported/regexp-stack.cc',
     'RegExpAPI.cpp',
+    'RegExpNativeMacroAssembler.cpp',
     'RegExpShim.cpp',
     'util/UnicodeShim.cpp'
 ]
-SOURCES += [
-    'RegExpNativeMacroAssembler.cpp'
-]
 
 if CONFIG['JS_HAS_INTL_API']:
     CXXFLAGS += ['-DV8_INTL_SUPPORT']
     UNIFIED_SOURCES += ['imported/property-sequences.cc',
                         'imported/special-case.cc']
 
 # Make sure all irregexp code is built with libfuzzer
 # coverage instrumentation in FUZZING mode.