Bug 1405942 - Make sure to always apply the descriptionHeightWorkaround in Photon panels on popupshown, because it might've missed elements that were hidden. r=Paolo, a=ritu
authorMike de Boer <mdeboer@mozilla.com>
Tue, 10 Oct 2017 12:42:43 +0200
changeset 432460 567e84287828cffa7f68dd45bcef816ee9525da5
parent 432459 261ad1333984d97f050d74157f52523098f7ff14
child 432461 2b1e17caa3146e55e1a87b1c87e3a0a27a5c4439
push id7956
push userryanvm@gmail.com
push dateThu, 12 Oct 2017 19:12:45 +0000
treeherdermozilla-beta@bfa99221e3af [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersPaolo, ritu
bugs1405942
milestone57.0
Bug 1405942 - Make sure to always apply the descriptionHeightWorkaround in Photon panels on popupshown, because it might've missed elements that were hidden. r=Paolo, a=ritu MozReview-Commit-ID: 9xSqoZGJ3MF
browser/components/customizableui/PanelMultiView.jsm
--- a/browser/components/customizableui/PanelMultiView.jsm
+++ b/browser/components/customizableui/PanelMultiView.jsm
@@ -1043,18 +1043,17 @@ this.PanelMultiView = class {
             blockInBoxWorkaround();
           }
         }
         break;
       }
       case "popupshown":
         // Now that the main view is visible, we can check the height of the
         // description elements it contains.
-        if (!this.panelViews)
-          this.descriptionHeightWorkaround();
+        this.descriptionHeightWorkaround();
         break;
       case "popuphidden": {
         // WebExtensions consumers can hide the popup from viewshowing, or
         // mid-transition, which disrupts our state:
         this._viewShowing = null;
         this._transitioning = false;
         this.node.removeAttribute("panelopen");
         this.showMainView();