Bug 1455026. Remove support for weak references from DOMParser. r=qdot
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 20 Apr 2018 23:04:46 -0400
changeset 468467 54cd958c5398e463a5a799526111c6abb7fc94af
parent 468466 757c523ca40f0d55e764e1c4f0685b3db3816c0d
child 468468 4d377882ca874a7babc58eccbe4020e79d648a1c
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersqdot
bugs1455026
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1455026. Remove support for weak references from DOMParser. r=qdot MozReview-Commit-ID: GYCJ2fu2ZI9
dom/base/DOMParser.cpp
dom/base/DOMParser.h
--- a/dom/base/DOMParser.cpp
+++ b/dom/base/DOMParser.cpp
@@ -43,17 +43,16 @@ DOMParser::DOMParser(nsIGlobalObject* aO
 DOMParser::~DOMParser()
 {
 }
 
 // QueryInterface implementation for DOMParser
 NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(DOMParser)
   NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY
   NS_INTERFACE_MAP_ENTRY(nsISupports)
-  NS_INTERFACE_MAP_ENTRY(nsISupportsWeakReference)
 NS_INTERFACE_MAP_END
 
 NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(DOMParser, mOwner)
 
 NS_IMPL_CYCLE_COLLECTING_ADDREF(DOMParser)
 NS_IMPL_CYCLE_COLLECTING_RELEASE(DOMParser)
 
 static const char*
--- a/dom/base/DOMParser.h
+++ b/dom/base/DOMParser.h
@@ -4,30 +4,29 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #ifndef mozilla_dom_DOMParser_h_
 #define mozilla_dom_DOMParser_h_
 
 #include "nsCOMPtr.h"
 #include "nsIDocument.h"
-#include "nsWeakReference.h"
 #include "nsWrapperCache.h"
 #include "mozilla/ErrorResult.h"
 #include "mozilla/Span.h"
 #include "mozilla/dom/DOMParserBinding.h"
 #include "mozilla/dom/TypedArray.h"
 
 class nsIDocument;
 class nsIGlobalObject;
 
 namespace mozilla {
 namespace dom {
 
-class DOMParser final : public nsSupportsWeakReference,
+class DOMParser final : public nsISupports,
                         public nsWrapperCache
 {
   typedef mozilla::dom::GlobalObject GlobalObject;
 
   virtual ~DOMParser();
 
 public:
   NS_DECL_CYCLE_COLLECTING_ISUPPORTS