Bug 1537992 - Rename Profiler button and modal in about:debugging r=Ola,flod
authorJulian Descottes <jdescottes@mozilla.com>
Mon, 29 Apr 2019 15:31:34 +0000
changeset 530617 53ffb5f187119724ba5942a4ef7470dc7a961221
parent 530616 e64b96d4af3d9d98b34541217f61ff138a1c7880
child 530618 ea8bdd612f43f22fa90fe1f87245e73fd1c5319d
push id11265
push userffxbld-merge
push dateMon, 13 May 2019 10:53:39 +0000
treeherdermozilla-beta@77e0fe8dbdd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersOla, flod
bugs1537992
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1537992 - Rename Profiler button and modal in about:debugging r=Ola,flod Differential Revision: https://phabricator.services.mozilla.com/D29135
devtools/client/aboutdebugging-new/src/components/ProfilerDialog.js
devtools/client/aboutdebugging-new/src/components/RuntimeActions.js
devtools/client/locales/en-US/aboutdebugging.ftl
--- a/devtools/client/aboutdebugging-new/src/components/ProfilerDialog.js
+++ b/devtools/client/aboutdebugging-new/src/components/ProfilerDialog.js
@@ -43,23 +43,23 @@ class ProfilerDialog extends PureCompone
           onClick: e => e.stopPropagation(),
         },
         dom.header(
           {
             className: "profiler-dialog__header",
           },
           Localized(
             {
-              id: "about-debugging-profiler-dialog-title",
+              id: "about-debugging-profiler-dialog-title2",
             },
             dom.h1(
               {
                 className: "profiler-dialog__header__title",
               },
-              "Performance Profiler",
+              "about-debugging-profiler-dialog-title2",
             )
           ),
           dom.button(
             {
               className: "ghost-button js-profiler-dialog-close",
               onClick: () => this.hide(),
             },
             dom.img(
--- a/devtools/client/aboutdebugging-new/src/components/RuntimeActions.js
+++ b/devtools/client/aboutdebugging-new/src/components/RuntimeActions.js
@@ -57,24 +57,24 @@ class RuntimeActions extends PureCompone
   }
 
   renderProfileButton() {
     const { runtimeId } = this.props;
 
     return runtimeId !== RUNTIMES.THIS_FIREFOX
          ? Localized(
            {
-             id: "about-debugging-runtime-profile-button",
+             id: "about-debugging-runtime-profile-button2",
            },
            dom.button(
              {
                className: "default-button js-profile-runtime-button",
                onClick: () => this.onProfilerButtonClick(),
              },
-             "Profile Runtime"
+             "about-debugging-runtime-profile-button2"
            ),
          )
          : null;
   }
 
   render() {
     return dom.div(
       {},
--- a/devtools/client/locales/en-US/aboutdebugging.ftl
+++ b/devtools/client/locales/en-US/aboutdebugging.ftl
@@ -198,17 +198,17 @@ about-debugging-runtime-shared-workers =
 about-debugging-runtime-other-workers =
   .name = Other Workers
 # Title of the processes category.
 about-debugging-runtime-processes =
   .name = Processes
 
 # Label of the button opening the performance profiler panel in runtime pages for remote
 # runtimes.
-about-debugging-runtime-profile-button = Profile Runtime
+about-debugging-runtime-profile-button2 = Profile performance
 
 # This string is displayed in the runtime page if the current configuration of the
 # target runtime is incompatible with service workers. "Learn more" points to MDN.
 # https://developer.mozilla.org/en-US/docs/Tools/about%3Adebugging#Service_workers_not_compatible
 about-debugging-runtime-service-workers-not-compatible = Your browser configuration is not compatible with Service Workers. <a>Learn more</a>
 
 # This string is displayed in the runtime page if the remote browser version is too old.
 # "Troubleshooting" link points to https://developer.mozilla.org/docs/Tools/WebIDE/Troubleshooting
@@ -245,17 +245,17 @@ about-debugging-runtime-disconnect-butto
 # "devtools.debugger.prompt-connection" is false on the target runtime.
 about-debugging-connection-prompt-enable-button = Enable connection prompt
 
 # Text of the connection prompt button displayed in Runtime pages, when the preference
 # "devtools.debugger.prompt-connection" is true on the target runtime.
 about-debugging-connection-prompt-disable-button = Disable connection prompt
 
 # Title of a modal dialog displayed on remote runtime pages after clicking on the Profile Runtime button.
-about-debugging-profiler-dialog-title = Performance Profiler
+about-debugging-profiler-dialog-title2 = Profiler
 
 # Label of a checkbox displayed in the runtime page for "This Firefox".
 # This checkbox will toggle preferences that enable local addon debugging.
 # The "Learn more" link points to MDN.
 # https://developer.mozilla.org/docs/Tools/about:debugging#Enabling_add-on_debugging
 about-debugging-extension-debug-setting-label = Enable extension debugging. <a>Learn more</a>
 
 # Clicking on the header of a debug target category will expand or collapse the debug