Bug 1118411 - Mark virtual overridden functions as MOZ_OVERRIDE in Gecko Profiler; r=BenWa
authorEhsan Akhgari <ehsan@mozilla.com>
Tue, 06 Jan 2015 15:10:37 -0500
changeset 248107 53e1120d30487db30df22a90a6d23b5430a853a8
parent 248106 3d94c5baadb0effa4e2cdc0fdefc5e946edb3f64
child 248108 cc8f76c2d74d6c15e80422c5f36955bde970d31e
push id4489
push userraliiev@mozilla.com
push dateMon, 23 Feb 2015 15:17:55 +0000
treeherdermozilla-beta@fd7c3dc24146 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersBenWa
bugs1118411
milestone37.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1118411 - Mark virtual overridden functions as MOZ_OVERRIDE in Gecko Profiler; r=BenWa
tools/profiler/SaveProfileTask.h
tools/profiler/ThreadResponsiveness.cpp
--- a/tools/profiler/SaveProfileTask.h
+++ b/tools/profiler/SaveProfileTask.h
@@ -38,17 +38,17 @@ public:
   typedef void (*AddSubProfileFunc)(const char* aProfile, void* aClosure);
   NS_DECL_ISUPPORTS
 
   ProfileSaveEvent(AddSubProfileFunc aFunc, void* aClosure)
     : mFunc(aFunc)
     , mClosure(aClosure)
   {}
 
-  NS_IMETHOD AddSubProfile(const char* aProfile);
+  NS_IMETHOD AddSubProfile(const char* aProfile) MOZ_OVERRIDE;
 private:
   ~ProfileSaveEvent() {}
 
   AddSubProfileFunc mFunc;
   void* mClosure;
 };
 
 #endif
--- a/tools/profiler/ThreadResponsiveness.cpp
+++ b/tools/profiler/ThreadResponsiveness.cpp
@@ -29,17 +29,17 @@ public:
 
 protected:
   ~CheckResponsivenessTask()
   {
     MOZ_COUNT_DTOR(CheckResponsivenessTask);
   }
 
 public:
-  NS_IMETHOD Run()
+  NS_IMETHOD Run() MOZ_OVERRIDE
   {
     MonitorAutoLock mon(mMonitor);
     if (mStop)
       return NS_OK;
 
     // This is raced on because we might pause the thread here
     // for profiling so if we tried to use a monitor to protect
     // mLastTracerTime we could deadlock. We're risking seeing