Bug 1390486 - Add "dom.file.createInChild" preference to recommended prefs. r=ato, a=test-only
authorHenrik Skupin <mail@hskupin.info>
Tue, 15 Aug 2017 17:47:15 +0200
changeset 421219 53842188fe9d8febf556feb4a68837ec030641fc
parent 421218 3145c49cc4161881309672ebc275c36f4c9a36c9
child 421220 0537e2f37ee1352b0f1b041fe4ead43eacc36365
push id7627
push userryanvm@gmail.com
push dateThu, 17 Aug 2017 17:56:52 +0000
treeherdermozilla-beta@91a92e4f9136 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersato, test-only
bugs1390486
milestone56.0
Bug 1390486 - Add "dom.file.createInChild" preference to recommended prefs. r=ato, a=test-only To allow geckodriver to create file objects in child processes, this preference has to be set to true. As such it needs to be recommended in Marionette and set as default preference for geckodriver. MozReview-Commit-ID: 8bdbi5jH6Vc
testing/geckodriver/CHANGES.md
testing/geckodriver/src/prefs.rs
testing/marionette/server.js
--- a/testing/geckodriver/CHANGES.md
+++ b/testing/geckodriver/CHANGES.md
@@ -1,14 +1,17 @@
 # Change log
 
 All notable changes to this program is documented in this file.
 
 ## Unreleased
 
+### Added
+- Added preference `dom.file.createInChild` set to true to allow file object creation in content processes.
+
 ### Changed
 - `/moz/addon/install` command accepts an `addon` parameter, in lieu of `path`, containing an add-on as a base64 string.
 
 ## 0.18.0 (2017-07-10)
 
 ### Changed
 - [`RectResponse`](https://docs.rs/webdriver/0.27.0/webdriver/response/struct.RectResponse.html) permits returning floats for `width` and `height` fields
 - New type [`CookieResponse`](https://docs.rs/webdriver/0.27.0/webdriver/response/struct.CookieResponse.html) for the [`GetNamedCookie` command](https://docs.rs/webdriver/0.27.0/webdriver/command/enum.WebDriverCommand.html#variant.GetNamedCookie) returns a single cookie, as opposed to an array of a single cookie
--- a/testing/geckodriver/src/prefs.rs
+++ b/testing/geckodriver/src/prefs.rs
@@ -1,12 +1,12 @@
 use mozprofile::preferences::Pref;
 
 lazy_static! {
-    pub static ref DEFAULT: [(&'static str, Pref); 79] = [
+    pub static ref DEFAULT: [(&'static str, Pref); 80] = [
         // Disable automatic downloading of new releases
         ("app.update.auto", Pref::new(false)),
 
         // Disable automatically upgrading Firefox
         ("app.update.enabled", Pref::new(false)),
 
         // Increase the APZ content response timeout in tests to 1
         // minute.  This is to accommodate the fact that test environments
@@ -119,16 +119,19 @@ lazy_static! {
         ("datareporting.healthreport.uploadEnabled", Pref::new(false)),
         ("datareporting.policy.dataSubmissionEnabled", Pref::new(false)),
         ("datareporting.policy.dataSubmissionPolicyAccepted", Pref::new(false)),
         ("datareporting.policy.dataSubmissionPolicyBypassNotification", Pref::new(true)),
 
         // Disable popup-blocker
         ("dom.disable_open_during_load", Pref::new(false)),
 
+        // Enabling the support for File object creation in the content process
+        ("dom.file.createInChild", Pref::new(true)),
+
         // Disable the ProcessHangMonitor
         ("dom.ipc.reportProcessHangs", Pref::new(false)),
 
         // Disable slow script dialogues
         ("dom.max_chrome_script_run_time", Pref::new(0)),
         ("dom.max_script_run_time", Pref::new(0)),
 
         // Only load extensions from the application and user profile
--- a/testing/marionette/server.js
+++ b/testing/marionette/server.js
@@ -178,16 +178,19 @@ const RECOMMENDED_PREFS = new Map([
   ["datareporting.healthreport.uploadEnabled", false],
   ["datareporting.policy.dataSubmissionEnabled", false],
   ["datareporting.policy.dataSubmissionPolicyAccepted", false],
   ["datareporting.policy.dataSubmissionPolicyBypassNotification", true],
 
   // Disable popup-blocker
   ["dom.disable_open_during_load", false],
 
+  // Enabling the support for File object creation in the content process
+  ["dom.file.createInChild", true],
+
   // Disable the ProcessHangMonitor
   ["dom.ipc.reportProcessHangs", false],
 
   // Disable slow script dialogues
   ["dom.max_chrome_script_run_time", 0],
   ["dom.max_script_run_time", 0],
 
   // Only load extensions from the application and user profile