Backed out 2 changesets (bug 1248459) for test_imestate.html failures in mochitest-chrome-3 runs
authorWes Kocher <wkocher@mozilla.com>
Fri, 26 Feb 2016 13:51:56 -0800
changeset 322224 53003fb5d81a7f1654a622e922f225da3b2ceb2e
parent 322223 c728ed2a0ba979418ce9ea98cfb45b55967cc7cb
child 322225 4c0b66b8076e69d5e537e8361f58240df1d6d2c2
push id5913
push userjlund@mozilla.com
push dateMon, 25 Apr 2016 16:57:49 +0000
treeherdermozilla-beta@dcaf0a6fa115 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1248459
milestone47.0a1
backs out62d7f81e434a07bcc00157cf827f179c5fbd8aaf
6aeedf17f57775ea7a0c8d5345b7e8d774ce9fb4
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 2 changesets (bug 1248459) for test_imestate.html failures in mochitest-chrome-3 runs Backed out changeset 62d7f81e434a (bug 1248459) Backed out changeset 6aeedf17f577 (bug 1248459) MozReview-Commit-ID: 10008f0KqYP
dom/events/ContentEventHandler.cpp
dom/events/test/mochitest.ini
dom/events/test/test_bug1248459.html
--- a/dom/events/ContentEventHandler.cpp
+++ b/dom/events/ContentEventHandler.cpp
@@ -1118,25 +1118,16 @@ static nsresult GetFrameForTextRect(nsIN
 nsresult
 ContentEventHandler::OnQuerySelectedText(WidgetQueryContentEvent* aEvent)
 {
   nsresult rv = Init(aEvent);
   if (NS_FAILED(rv)) {
     return rv;
   }
 
-  nsINode* const startNode = mFirstSelectedRange->GetStartParent();
-  nsINode* const endNode = mFirstSelectedRange->GetEndParent();
-
-  // Make sure the selection is within the root content range.
-  if (!nsContentUtils::ContentIsDescendantOf(startNode, mRootContent) ||
-      !nsContentUtils::ContentIsDescendantOf(endNode, mRootContent)) {
-    return NS_ERROR_NOT_AVAILABLE;
-  }
-
   NS_ASSERTION(aEvent->mReply.mString.IsEmpty(),
                "The reply string must be empty");
 
   LineBreakType lineBreakType = GetLineBreakType(aEvent);
   rv = GetFlatTextLengthBefore(mFirstSelectedRange,
                                &aEvent->mReply.mOffset, lineBreakType);
   NS_ENSURE_SUCCESS(rv, rv);
 
--- a/dom/events/test/mochitest.ini
+++ b/dom/events/test/mochitest.ini
@@ -140,17 +140,16 @@ skip-if = toolkit == "gonk" || e10s
 [test_bug998809.html]
 [test_bug1017086_disable.html]
 support-files = bug1017086_inner.html
 [test_bug1017086_enable.html]
 support-files = bug1017086_inner.html
 [test_bug1079236.html]
 [test_bug1145910.html]
 [test_bug1150308.html]
-[test_bug1248459.html]
 [test_clickevent_on_input.html]
 skip-if = toolkit == 'android' #CRASH_DUMP, RANDOM
 [test_continuous_wheel_events.html]
 skip-if = buildapp == 'b2g' || e10s # b2g(5535 passed, 108 failed - more tests running than desktop) b2g-debug(5535 passed, 108 failed - more tests running than desktop) b2g-desktop(5535 passed, 108 failed - more tests running than desktop)
 [test_dblclick_explicit_original_target.html]
 [test_dom_keyboard_event.html]
 skip-if = toolkit == 'android' #CRASH_DUMP, RANDOM
 [test_dom_mouse_event.html]
deleted file mode 100644
--- a/dom/events/test/test_bug1248459.html
+++ /dev/null
@@ -1,58 +0,0 @@
-<!DOCTYPE HTML>
-<html>
-<!--
-https://bugzilla.mozilla.org/show_bug.cgi?id=1248459
--->
-<head>
-  <title>Test for Bug 1248459</title>
-  <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
-  <script type="application/javascript" src="/tests/SimpleTest/EventUtils.js"></script>
-  <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
-</head>
-<body>
-<input id="input" value="foo">
-<div id="div">bar</div>
-<script type="application/javascript">
-
-/** Test for Bug 1248459 **/
-/**
- * The bug occurs when a piece of text outside of the editor's root element is
- * somehow selected when the editor is focused. In the bug's case, it's the
- * placeholder anonymous div that's selected. In this test's case, it's a
- * document div that's selected.
- */
-SimpleTest.waitForExplicitFinish();
-
-SimpleTest.waitForFocus(function() {
-  var div = document.getElementById("div");
-  var input = document.getElementById("input");
-
-  input.appendChild(div);
-  input.focus();
-
-  var editor = SpecialPowers.wrap(input).editor;
-  var sel = editor.selection;
-
-  sel.selectAllChildren(editor.rootElement);
-  var result = synthesizeQuerySelectedText();
-
-  ok(result.succeeded, "Query selected text should succeed");
-  is(result.offset, 0, "Selected text should be at offset 0");
-  is(result.text, "foo", "Selected text should match");
-
-  var range = document.createRange();
-  range.selectNode(div);
-
-  sel.removeAllRanges();
-  sel.addRange(range);
-
-  result = synthesizeQuerySelectedText();
-
-  ok(!result.succeeded, "Query out-of-bounds selection should fail");
-
-  SimpleTest.finish();
-});
-
-</script>
-</body>
-</html>