author | Karl Tomlinson <karlt+@karlt.net> |
Fri, 25 Oct 2013 14:05:43 +1300 | |
changeset 165864 | 52abf1613764f10208513fcdbb8f4ad34e08a1fa |
parent 165863 | c91ae6b8208cdd9dcd87233ebc2d4debcaeca589 |
child 165865 | 578c80c21547cdaab10b80426246dca7e18d0b68 |
push id | 3066 |
push user | akeybl@mozilla.com |
push date | Mon, 09 Dec 2013 19:58:46 +0000 |
treeherder | mozilla-beta@a31a0dce83aa [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | ehsan |
bugs | 898291 |
milestone | 27.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/content/media/webaudio/PannerNode.cpp +++ b/content/media/webaudio/PannerNode.cpp @@ -38,19 +38,17 @@ NS_IMPL_ADDREF_INHERITED(PannerNode, Aud NS_IMPL_RELEASE_INHERITED(PannerNode, AudioNode) class PannerNodeEngine : public AudioNodeEngine { public: explicit PannerNodeEngine(AudioNode* aNode) : AudioNodeEngine(aNode) // Please keep these default values consistent with PannerNode::PannerNode below. - , mPanningModel(PanningModelType::HRTF) , mPanningModelFunction(&PannerNodeEngine::HRTFPanningFunction) - , mDistanceModel(DistanceModelType::Inverse) , mDistanceModelFunction(&PannerNodeEngine::InverseGainFunction) , mPosition() , mOrientation(1., 0., 0.) , mVelocity() , mRefDistance(1.) , mMaxDistance(10000.) , mRolloffFactor(1.) , mConeInnerAngle(360.) @@ -66,32 +64,30 @@ public: HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary(aNode->Context()->SampleRate()); mHRTFPanner = new HRTFPanner(aNode->Context()->SampleRate(), loader); } virtual void SetInt32Parameter(uint32_t aIndex, int32_t aParam) MOZ_OVERRIDE { switch (aIndex) { case PannerNode::PANNING_MODEL: - mPanningModel = PanningModelType(aParam); - switch (mPanningModel) { + switch (PanningModelType(aParam)) { case PanningModelType::Equalpower: mPanningModelFunction = &PannerNodeEngine::EqualPowerPanningFunction; break; case PanningModelType::HRTF: mPanningModelFunction = &PannerNodeEngine::HRTFPanningFunction; break; default: NS_NOTREACHED("We should never see the alternate names here"); break; } break; case PannerNode::DISTANCE_MODEL: - mDistanceModel = DistanceModelType(aParam); - switch (mDistanceModel) { + switch (DistanceModelType(aParam)) { case DistanceModelType::Inverse: mDistanceModelFunction = &PannerNodeEngine::InverseGainFunction; break; case DistanceModelType::Linear: mDistanceModelFunction = &PannerNodeEngine::LinearGainFunction; break; case DistanceModelType::Exponential: mDistanceModelFunction = &PannerNodeEngine::ExponentialGainFunction; @@ -157,20 +153,18 @@ public: void EqualPowerPanningFunction(const AudioChunk& aInput, AudioChunk* aOutput); void HRTFPanningFunction(const AudioChunk& aInput, AudioChunk* aOutput); float LinearGainFunction(float aDistance); float InverseGainFunction(float aDistance); float ExponentialGainFunction(float aDistance); nsAutoPtr<HRTFPanner> mHRTFPanner; - PanningModelType mPanningModel; typedef void (PannerNodeEngine::*PanningModelFunction)(const AudioChunk& aInput, AudioChunk* aOutput); PanningModelFunction mPanningModelFunction; - DistanceModelType mDistanceModel; typedef float (PannerNodeEngine::*DistanceModelFunction)(float aDistance); DistanceModelFunction mDistanceModelFunction; ThreeDPoint mPosition; ThreeDPoint mOrientation; ThreeDPoint mVelocity; double mRefDistance; double mMaxDistance; double mRolloffFactor;