Bug 1001936 - Clear the value cache when the editor is being destroyed because it won't get updated when we don't have a bound frame; r=bzbarsky
authorEhsan Akhgari <ehsan@mozilla.com>
Sun, 27 Apr 2014 09:33:24 -0400
changeset 198965 523b23877c53dc3745200c849218f3219f7e50f5
parent 198964 eadb8b61b59acfa9e8224b606818f9d37679967f
child 198966 b9ed93ef1d238e04ae9a9ee107538fc6ddc20d11
push id3624
push userasasaki@mozilla.com
push dateMon, 09 Jun 2014 21:49:01 +0000
treeherdermozilla-beta@b1a5da15899a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbzbarsky
bugs1001936
milestone31.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1001936 - Clear the value cache when the editor is being destroyed because it won't get updated when we don't have a bound frame; r=bzbarsky
content/html/content/src/nsTextEditorState.cpp
--- a/content/html/content/src/nsTextEditorState.cpp
+++ b/content/html/content/src/nsTextEditorState.cpp
@@ -1424,16 +1424,17 @@ nsTextEditorState::DestroyEditor()
   // notify the editor that we are going away
   if (mEditorInitialized) {
     if (mTextListener)
       mEditor->RemoveEditorObserver(mTextListener);
 
     mEditor->PreDestroy(true);
     mEditorInitialized = false;
   }
+  ClearValueCache();
 }
 
 void
 nsTextEditorState::UnbindFromFrame(nsTextControlFrame* aFrame)
 {
   NS_ENSURE_TRUE_VOID(mBoundFrame);
 
   // If it was, however, it should be unbounded from the same frame.