Bug 1325814 - Clarify file overview comment in ExtensionChild.jsm r=mixedpuppy
authorRob Wu <rob@robwu.nl>
Thu, 02 Aug 2018 23:16:46 +0200
changeset 486149 51d530820c10c71944b73decd7ba5f489d0a0245
parent 486148 01a46abce8fa48d11860f928e44b46d1e90eaae8
child 486150 f47fc4512dfb3975e15e6af96c1f9886a6863f9a
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy
bugs1325814, 1317697
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1325814 - Clarify file overview comment in ExtensionChild.jsm r=mixedpuppy At its inception, ExtensionChild.jsm was meant to be used for the extension child process. Over time, this intent was not consistently followed, and in bug 1317697 this was fixed by splitting some logic in ExtensionChild.jsm off to ExtensionPageChild.jsm. Henceforth ExtensionChild.jsm handles logic that is common to all content processes, including web content and extension logic. Updated the comment at the top of the file to match this reality. MozReview-Commit-ID: 3cAd0FPj6Vz
toolkit/components/extensions/ExtensionChild.jsm
--- a/toolkit/components/extensions/ExtensionChild.jsm
+++ b/toolkit/components/extensions/ExtensionChild.jsm
@@ -4,20 +4,19 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 "use strict";
 
 /* exported ExtensionChild */
 
 var EXPORTED_SYMBOLS = ["ExtensionChild"];
 
-/*
- * This file handles addon logic that is independent of the chrome process.
- * When addons run out-of-process, this is the main entry point.
- * Its primary function is managing addon globals.
+/**
+ * This file handles addon logic that is independent of the chrome process and
+ * may run in all web content and extension processes.
  *
  * Don't put contentscript logic here, use ExtensionContent.jsm instead.
  */
 
 ChromeUtils.import("resource://gre/modules/Services.jsm");
 ChromeUtils.import("resource://gre/modules/XPCOMUtils.jsm");
 
 XPCOMUtils.defineLazyServiceGetter(this, "finalizationService",