Bug 661045: Devirtualize some RasterImage methods. r=joe
authorKyle Huey <khuey@kylehuey.com>
Sat, 11 Jun 2011 12:23:00 -0700
changeset 71436 51b64ac421e383660da14a3a7e4752a6d960f65c
parent 71435 980984f268ef1b3804087362204cd02c8ee3e3e9
child 71437 5bb18a13d2b99bc3ac093add70abcfcd27a2ba12
push id159
push usereakhgari@mozilla.com
push dateTue, 16 Aug 2011 17:53:11 +0000
treeherdermozilla-beta@8786e3e49240 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 661045: Devirtualize some RasterImage methods. r=joe
--- a/modules/libpr0n/src/RasterImage.h
+++ b/modules/libpr0n/src/RasterImage.h
@@ -271,33 +271,33 @@ public:
    * decode the image.
    * XXX This method's only caller (WriteToContainer) ignores the return
    * value. Should this just return void?
   nsresult AddSourceData(const char *aBuffer, PRUint32 aCount);
   /* Called after the all the source data has been added with addSourceData. */
-  virtual nsresult SourceDataComplete();
+  nsresult SourceDataComplete();
   /* Called for multipart images when there's a new source image to add. */
-  virtual nsresult NewSourceData();
+  nsresult NewSourceData();
    * A hint of the number of bytes of source data that the image contains. If
    * called early on, this can help reduce copying and reallocations by
    * appropriately preallocating the source data buffer.
    * We take this approach rather than having the source data management code do
    * something more complicated (like chunklisting) because HTTP is by far the
    * dominant source of images, and the Content-Length header is quite reliable.
    * Thus, pre-allocation simplifies code and reduces the total number of
    * allocations.
-  virtual nsresult SetSourceSizeHint(PRUint32 sizeHint);
+  nsresult SetSourceSizeHint(PRUint32 sizeHint);
   // "Blend" method indicates how the current image is combined with the
   // previous image.
   enum {
     // All color components of the frame, including alpha, overwrite the current
     // contents of the frame's output buffer region
     kBlendSource =  0,