Bug 523374: Trying to save a bookmark with an empty name fails [r=vingtetun]
authorMark Finkle <mfinkle@mozilla.com>
Tue, 24 Nov 2009 09:37:26 -0500
changeset 65840 518661d1d4792ee6ff7674c4d912e2f12fe943da
parent 65839 2698df99f378bded175a91da736b9d8b5f62e7ac
child 65841 e92a536dfacfc393b73ca74ee7d4a61dcb35667f
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersvingtetun
bugs523374
Bug 523374: Trying to save a bookmark with an empty name fails [r=vingtetun]
mobile/chrome/content/bindings.xml
--- a/mobile/chrome/content/bindings.xml
+++ b/mobile/chrome/content/bindings.xml
@@ -503,21 +503,21 @@
                 try {
                   this._uri = this._ioService.newURI(spec, null, null);
                   PlacesUtils.bookmarks.changeBookmarkURI(this.itemId, this.uri);
                   this.setAttribute('uri', this.spec);
                 }
                 catch (e) { }
               }
               if (spec != this.uri.spec)
-                spec = this.spec = this.uri.spec;
+                this.spec = this.uri.spec;
             }
 
             // Update the name and use the URI if name is blank
-            this.name = this.name || spec;
+            this.name = this.name || this.spec;
             this.setAttribute('title', this.name);
             PlacesUtils.bookmarks.setItemTitle(this.itemId, this.name);
           ]]>
         </body>
       </method>
       <method name="remove">
         <body>
           <![CDATA[