Remove browser-based jstests' requirement that tests must be nested *at least* two levels deep, i.e. js/src/tests/suite/subsuite/foo.js. jstests.py enforces no such restriction, and this just ends up meaning silent failures when someone forgets about this. :-( No bug (but a prerequisite to bug 1263040 landing), rs=efaust
authorJeff Walden <jwalden@mit.edu>
Wed, 20 Apr 2016 19:04:44 -0700
changeset 332074 5177d7cdb97fb0616b27a877047c4f08a67e5fdc
parent 332073 9e0834bfce332e669f3a82414221c97822773345
child 332075 b6cd434fdaf5f9471c4f17e23876143718a1e3c0
push id6048
push userkmoir@mozilla.com
push dateMon, 06 Jun 2016 19:02:08 +0000
treeherdermozilla-beta@46d72a56c57d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersefaust
bugs1263040
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Remove browser-based jstests' requirement that tests must be nested *at least* two levels deep, i.e. js/src/tests/suite/subsuite/foo.js. jstests.py enforces no such restriction, and this just ends up meaning silent failures when someone forgets about this. :-( No bug (but a prerequisite to bug 1263040 landing), rs=efaust
js/src/tests/browser.js
--- a/js/src/tests/browser.js
+++ b/js/src/tests/browser.js
@@ -366,19 +366,19 @@ function jsTestDriverBrowserInit()
    * in shell tests as the default jit setting has not changed there.
    */
 
   if (properties.jit  || !document.location.href.match(/jsreftest.html/))
     jit(properties.jit);
 
   var testpathparts = properties.test.split(/\//);
 
-  if (testpathparts.length < 3)
+  if (testpathparts.length < 2)
   {
-    // must have at least suitepath/subsuite/testcase.js
+    // must have at least suitepath/testcase.js
     return;
   }
 
   document.write('<title>' + properties.test + '<\/title>');
 
   // XXX bc - the first document.written script is ignored if the protocol
   // is file:. insert an empty script tag, to work around it.
   document.write('<script></script>');