Bug 1529305 - Emit cv8 debug info with nasm even on mingw. r=firefox-build-system-reviewers,mshal
authorThomas Daede <tdaede@mozilla.com>
Thu, 28 Feb 2019 00:42:34 +0000
changeset 519691 512b63ef9f71910c7d49cd5d5bc332efae84bdf9
parent 519690 f89aa19d37be3281be2ac835f1704746dfa68b2e
child 519692 c13d34779fe8bdbe75ef8ab58f5da88f1d017dbc
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfirefox-build-system-reviewers, mshal
bugs1529305
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1529305 - Emit cv8 debug info with nasm even on mingw. r=firefox-build-system-reviewers,mshal Differential Revision: https://phabricator.services.mozilla.com/D21437
python/mozbuild/mozbuild/frontend/context.py
--- a/python/mozbuild/mozbuild/frontend/context.py
+++ b/python/mozbuild/mozbuild/frontend/context.py
@@ -362,18 +362,17 @@ class AsmFlags(BaseCompileFlags):
         )
         BaseCompileFlags.__init__(self, context)
 
     def _debug_flags(self):
         debug_flags = []
         if (self._context.config.substs.get('MOZ_DEBUG') or
             self._context.config.substs.get('MOZ_DEBUG_SYMBOLS')):
             if self._context.get('USE_NASM'):
-                if (self._context.config.substs.get('OS_ARCH') == 'WINNT' and
-                    not self._context.config.substs.get('GNU_CC')):
+                if self._context.config.substs.get('OS_ARCH') == 'WINNT':
                     debug_flags += ['-F', 'cv8']
                 elif self._context.config.substs.get('OS_ARCH') != 'Darwin':
                     debug_flags += ['-F', 'dwarf']
             elif self._context.get('USE_YASM'):
                 if (self._context.config.substs.get('OS_ARCH') == 'WINNT' and
                     not self._context.config.substs.get('GNU_CC')):
                     debug_flags += ['-g', 'cv8']
                 elif self._context.config.substs.get('OS_ARCH') != 'Darwin':