Bug 900200 - Fix strange transparent areas appearing in some APNG files. r=seth, a=bajaj
authorMax Stepin <newstop@gmail.com>
Tue, 27 Aug 2013 14:50:59 -0700
changeset 153908 507a9fc2d45b100038d5f74f5c78c1fc3ebf85f9
parent 153907 47e89ff8715c00fee269a54f652b41952f0ac658
child 153909 d834dfe34a299654e6a48311d37bd5c5b30d1cb5
push id2859
push userakeybl@mozilla.com
push dateMon, 16 Sep 2013 19:14:59 +0000
treeherdermozilla-beta@87d3c51cd2bf [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersseth, bajaj
bugs900200
milestone25.0a2
Bug 900200 - Fix strange transparent areas appearing in some APNG files. r=seth, a=bajaj
image/src/FrameBlender.cpp
image/test/reftest/animated/bug900200-ref.png
image/test/reftest/animated/bug900200.png
image/test/reftest/animated/reftest.list
--- a/image/src/FrameBlender.cpp
+++ b/image/src/FrameBlender.cpp
@@ -521,17 +521,17 @@ FrameBlender::DrawFrameTo(const uint8_t 
 
     pixman_image_composite32(aBlendMethod == FrameBlender::kBlendSource ? PIXMAN_OP_SRC : PIXMAN_OP_OVER,
                              src,
                              nullptr,
                              dst,
                              0, 0,
                              0, 0,
                              aSrcRect.x, aSrcRect.y,
-                             aDstRect.width, aDstRect.height);
+                             aSrcRect.width, aSrcRect.height);
 
     pixman_image_unref(src);
     pixman_image_unref(dst);
   }
 
   return NS_OK;
 }
 
new file mode 100644
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..636013132500247606f272dfaa84e5d66f45fffb
GIT binary patch
literal 660
zc$@*00&D$=P)<h;3K|Lk000e1NJLTq003kF003kN0ssI2|9}Dm00078Nkl<Zc-rlq
z+m3@U3`E0-|NrIgQzfciHX*)yct#ofcpM0n<{0BKe2>R5d*<OB>fr!uo=z}!R<NW1
zxq{P&rH#oDnHnrhMpo1mVEJOwL?#L=4kjIBC{9W=FbQXc#UyPpbRi`X>V~rtVG^<!
z+L77_9_>hNq=1g3?k0k!q;92yzNFTZLTgfssi8Zml>|Xj^J#*l=99(XAv3|ZveiV&
zAgTGp*@pXV*w$7*)Bp5{#)H&vO`o@`Z>ndCmB#f<$Jf$t&N8vpzK9XBSD7=cn`Xu_
zb{Q;fB|f}*8@vjfxeVoNF{CDCd;y2HpxJ$hme6Hf6ezfv9Q1TtRskxa&q2913^2hv
zE-v+?QH+#o0N^u*dHkqnE4?r{!TZ4q)zIR>&{<2cIJ-|9mCkZ%!+;)@4T;VoEW#oz
z!Xhjlghg0{RSK5(KMAOZL}x9*3h0NJ$MK-E{Ms;-O~r$uvs_^XF_%Ud2zt#Ac@Kgt
zRgDk;a)s+F%?bVnEQNBom`g?UIVh5Lgo_-srObF~30=lTfr6Wr<g_fi##>m+PKTwk
z`0(nae81h1vY5}M*71A8dpdTQLVa&|4JP8pnN!Xh{7LTT`XF>EgDo$)HWXP%w>8)I
z#F1cL4YRyt8;Z1HLv#I?EcS<JLTb7V%k!E`5VFG+Cbc-hm*lmQ6!eBJM(WnBLm6J{
ziNHpt0I7|e($u`}2EV=2K(2>5do_lyd?Hdqa(9%-789x{q6HL|)ZivX-moGdOSAoz
uBekp>s~ICJvSpthxU!o;im>y(;Qj&kAj_*L-&R2Y0000<MNUMnLSTZvfi))p
new file mode 100644
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..d7d87adce09ac7655ab4de9ebbb4bc7791bdd739
GIT binary patch
literal 840
zc%17D@N?(olHy`uVBq!ia0vp^DIm<j1SJ1AFfjuuj>O~;A0Q19Vr=PJ{0vA-r9s3P
zU>X=;fDy#D>9i67GEaNDIEGZ*dV4ol=#T=BYhcCi`^B-2xe5=Br{9k{`B612T_#J@
zKXUiHtlE^=Jy&-zoL;wi=3SjN8Vi;dJl^PL?5iT(W_mee+AW4PTYZ#II&J)xDCNBD
z^in5tv59MPXD(7+rV}I>U8?e0VcCKX&AC&OKYOV^)o_$tTE!h0v~pe1l<-x1HI`1x
z((%2yG>S_k=$ldNl)Vw6VP_irMYWwzI-QEM$bFH2c+19L(fcNBs=nAZ&rBuky@<+c
z>&PRo@^^TIU6HkUE!r*j=atK(s}psSQaQv=CLL(r$}Yxy+H9MLST2WHg!<ZDf9`9j
zaO-SPU;q*an7DN~K*WZ;qpSYBNr?Wc7`a6;B0;wOXpgy1`6O5Armeza$*;2$Ca!sB
zrV>-1?7B(f!{iMwj(nF>i981s0os4s@&V^{?xr{VzIv|GZg<m{@?Nig_^LX}N%NM$
zx7U8F3Tj2Q|Eo^&n0fm{m40+%*WNovgL;|&d99ze$mHFn>7J!`tzsTujq7-}=L~C5
z-|S0^_g0y|x66F6=70F_d&z5Se>N}idh$}k+Fj>`?A1K!TVbmTJT7Lfkv-98`7dkX
zt(EMnebsh9IkB&>;JO@}WYYFu%-`AH<+d&TV{7smDe@VC*a(Ux!5AF*??1^W0eLsl
zQXE4-$tL3P+ncBPS``GC177_9Z>*PBlw8wupg}k7&a4Z`hAt}0C+%84Y3=TthDCX)
zH>U(1VGEOA!5@C~Q*%^d#mx}Q1y`>X1k~mx%zVSK!KX~1Lrs}4=5nmYq$jLZq0=u0
z7|dn7HQ8hRs{;ag-b+^1CTi;l9F+QFDm__ZO#-WSg!e|4=|5wVg!UhrRJFHG;;pBM
z=9}{q>Yu)Beak5Dv&qgye^Xu{mvwv7KFM7@%;mGo#91D(UFxW?J38az<0l_yK9o;7
o=2rJ~v4(x#ql2;97ma^Q-xqcY-1^F6D=4*ly85}Sb4q9e00<^u0{{R3
--- a/image/test/reftest/animated/reftest.list
+++ b/image/test/reftest/animated/reftest.list
@@ -5,11 +5,12 @@
 == delay-test.html?keep.gif no-delay-test.html?green.png
 == delay-test.html?keep.png no-delay-test.html?green.png
 == delay-test.html?restore-previous.gif no-delay-test.html?green.png
 == delay-test.html?restore-previous.png no-delay-test.html?green.png
 
 # Test of the blending/compositing operator that only APNG supports.
 == delay-test.html?over.png no-delay-test.html?grey.png
 != delay-test.html?source.png no-delay-test.html?grey.png
+== delay-test.html?bug900200.png no-delay-test.html?bug900200-ref.png
 
 # Test of subframe updates
 == delay-test.html?clear2.gif no-delay-test.html?clear2-results.gif