Bug 1550596: Remove overly broad keep rule from GV proguard rules. r=snorp,agi
authorWill Hawkins <whawkins@mozilla.com>
Mon, 13 May 2019 21:35:09 +0000
changeset 532501 4fbfc8798cad0ecc7ae867ed943b91b24789a500
parent 532500 59841dabe8e1abd284a7e3b14d98e69861c0e2a2
child 532502 2c0de6646a6199e4558a4bf6279f7250302fc172
push id11268
push usercsabou@mozilla.com
push dateTue, 14 May 2019 15:24:22 +0000
treeherdermozilla-beta@5fb7fcd568d6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssnorp, agi
bugs1550596
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1550596: Remove overly broad keep rule from GV proguard rules. r=snorp,agi Requesting reviewers based on `hg blame` output and general knowledge of who is working on the project. I hope that's okay. Differential Revision: https://phabricator.services.mozilla.com/D30580
mobile/android/geckoview/proguard-rules.txt
--- a/mobile/android/geckoview/proguard-rules.txt
+++ b/mobile/android/geckoview/proguard-rules.txt
@@ -1,21 +1,14 @@
 # Modified from https://robotsandpencils.com/blog/use-proguard-android-library/.
 
 # Preserve all annotations.
 
 -keepattributes *Annotation*
 
-# Preserve all public classes, and their public and protected fields and
-# methods.
-
--keep public class * {
-    static public protected *;
-}
-
 # Preserve all .class method names.
 
 -keepclassmembernames class * {
     java.lang.Class class$(java.lang.String);
     java.lang.Class class$(java.lang.String, boolean);
 }
 
 # Preserve all native method names and the names of their classes.