Comment out just the one failing part, not hte whole test.
authorbzbarsky@mit.edu
Mon, 02 Apr 2007 13:48:25 -0700
changeset 273 4fa70bd911543e1150d3be3509381a5630090cb8
parent 272 2377528d47a111aa89ac39e7056bf96db2282ed3
child 274 7834f7fe93f5c1bd75e000d92280b63d1b2c5e5c
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone1.9a4pre
Comment out just the one failing part, not hte whole test.
dom/src/jsurl/test/test_bug351633-3.html
--- a/dom/src/jsurl/test/test_bug351633-3.html
+++ b/dom/src/jsurl/test/test_bug351633-3.html
@@ -60,17 +60,22 @@ function test3() {
     // Ignore this call; we expect the javascript: URI to still load.  Note
     // that whether onload fires for the fail.html load before the event for
     // the javascript: URI execution runs is a timing issue, so we can't depend
     // on the ordering.    
     return;
   }
 
   // Since fail.html could have loaded, the value of passJSUrl here is random
-  is(passJSUrl2, true, "<script> should have run");
+
+  // Something is bogus here.  Maybe we're ending up with the href being the
+  // javascript: URI even though it hasn't run yet?  Or something?  In any
+  // case, this test fails on some tinderboxen but not others....  Need to
+  // sort it out.  
+  // is(passJSUrl2, true, "<script> should have run");
 
   passJSUrl = false;
   passJSUrl2 = true;
   finishTest = function() { };
 
   window.testframe4.location.href = 'pass.html';
   window.testframe4.location.href =
     'javascript:void("<script>parent.passJSUrl2 = false</' + 'script>")'; 
@@ -91,18 +96,18 @@ function test4() {
 
 function test5() {
   is(passJSUrl, true, "pass.html should have loaded yet again");
   is(passJSUrl2, true, "javascript: load should have been canceled");
 
   SimpleTest.finish();
 }
 
-//SimpleTest.waitForExplicitFinish();
-//addLoadEvent(runTests);
+SimpleTest.waitForExplicitFinish();
+addLoadEvent(runTests);
 
 </script>
 </pre>
 <p id="display">
   <iframe name="testframe1" id="testframe1"></iframe>
   <iframe name="testframe2" id="testframe2"></iframe>
   <iframe name="testframe3" id="testframe3"></iframe>
   <iframe name="testframe4" id="testframe4"></iframe>