Remove some extraneous includes and a function, all added in bug 714260. They were initially necessary when that patch was written, but they became vestigial during rebasing prior to landing, and this disuse wasn't noticed til now. r=lumpy
authorJeff Walden <jwalden@mit.edu>
Thu, 19 Apr 2012 16:36:31 -0700
changeset 100671 4f44ffa3f9ff91a18d6bb493c9fec7b32045fbe7
parent 100670 e7334bfb16b1b6cc6d84786f943e26f66088eb66
child 100672 1a0f4431003105008d31616e75b8db2d3291d54f
push id1316
push userakeybl@mozilla.com
push dateMon, 27 Aug 2012 22:37:00 +0000
treeherdermozilla-beta@db4b09302ee2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslumpy
bugs714260
milestone16.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Remove some extraneous includes and a function, all added in bug 714260. They were initially necessary when that patch was written, but they became vestigial during rebasing prior to landing, and this disuse wasn't noticed til now. r=lumpy
js/src/jsval.h
mfbt/FloatingPoint.h
--- a/js/src/jsval.h
+++ b/js/src/jsval.h
@@ -7,18 +7,16 @@
 
 #ifndef jsvalimpl_h__
 #define jsvalimpl_h__
 
 /*
  * Implementation details for js::Value in jsapi.h.
  */
 
-#include "mozilla/FloatingPoint.h"
-
 #include "js/Utility.h"
 
 JS_BEGIN_EXTERN_C
 
 /*
  * Try to get jsvals 64-bit aligned. We could almost assert that all values are
  * aligned, but MSVC and GCC occasionally break alignment.
  */
--- a/mfbt/FloatingPoint.h
+++ b/mfbt/FloatingPoint.h
@@ -221,26 +221,16 @@ MOZ_DOUBLE_NaN()
 static MOZ_ALWAYS_INLINE double
 MOZ_DOUBLE_MIN_VALUE()
 {
   union MozDoublePun pun;
   pun.u = 1;
   return pun.d;
 }
 
-/** Computes a 32-bit hash of the given double. */
-static MOZ_ALWAYS_INLINE uint32_t
-MOZ_HASH_DOUBLE(double d)
-{
-  union MozDoublePun pun;
-  pun.d = d;
-
-  return ((uint32_t)(pun.u >> 32)) ^ ((uint32_t)(pun.u));
-}
-
 static MOZ_ALWAYS_INLINE int
 MOZ_DOUBLE_IS_INT32(double d, int32_t* i)
 {
   /*
    * XXX Casting a double that doesn't truncate to int32_t, to int32_t, induces
    *     undefined behavior.  We should definitely fix this (bug 744965), but as
    *     apparently it "works" in practice, it's not a pressing concern now.
    */