Bug 1528323 - Part 2: Mark some wpt as passing, and fix some others. Also fix a mochitest. r=jib
☠☠ backed out by bd76311c316a ☠ ☠
authorByron Campen [:bwc] <docfaraday@gmail.com>
Mon, 25 Feb 2019 14:53:03 +0000
changeset 519335 4ec8d35bbefce1c9dc0feccd1165933f831c855f
parent 519334 be1db93b9ba737fe549c10cd7d762d0cec87da10
child 519336 e5644fcedb190f861720b65572f7ca31a63fc321
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1528323
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1528323 - Part 2: Mark some wpt as passing, and fix some others. Also fix a mochitest. r=jib Differential Revision: https://phabricator.services.mozilla.com/D19985
dom/media/tests/mochitest/test_peerConnection_close.html
testing/web-platform/meta/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html.ini
testing/web-platform/tests/webrtc/RTCRtpTransceiver.https.html
--- a/dom/media/tests/mochitest/test_peerConnection_close.html
+++ b/dom/media/tests/mochitest/test_peerConnection_close.html
@@ -86,17 +86,17 @@
         [pc.setLocalDescription(offer), "setLocalDescription"],
         [pc.setRemoteDescription(answer), "setRemoteDescription"],
         [pc.addIceCandidate(candidate), "addIceCandidate"],
         [new Promise((y, n) => pc.createOffer(y, n)), "Legacy createOffer"],
         [new Promise((y, n) => pc.createAnswer(y, n)), "Legacy createAnswer"],
         [new Promise((y, n) => pc.setLocalDescription(offer, y, n)), "Legacy setLocalDescription"],
         [new Promise((y, n) => pc.setRemoteDescription(answer, y, n)), "Legacy setRemoteDescription"],
         [new Promise((y, n) => pc.addIceCandidate(candidate, y, n)), "Legacy addIceCandidate"],
-        [sender.replaceTrack(getBlackTrack()), "replaceTrack"],
+        [sender.replaceTrack(getSilentTrack()), "replaceTrack"],
       ].map(([p, name]) => doesFail(p, name + " fails on close")))
       .catch(reason => ok(false, "unexpected failure: " + reason))
       .then(finish);
 
       // Other methods are unaffected.
 
       SimpleTest.doesThrow(function() {
         pc.updateIce("Invalid RTC Configuration")},
deleted file mode 100644
--- a/testing/web-platform/meta/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html.ini
+++ /dev/null
@@ -1,10 +0,0 @@
-[RTCPeerConnection-setRemoteDescription-replaceTrack.https.html]
-  [replaceTrack() does not set the track synchronously.]
-    expected: FAIL
-
-  [replaceTrack() rejects after a subsequent removeTrack().]
-    expected: FAIL
-
-  [replaceTrack() does not reject after a subsequent removeTrack().]
-    expected: FAIL
-
--- a/testing/web-platform/tests/webrtc/RTCRtpTransceiver.https.html
+++ b/testing/web-platform/tests/webrtc/RTCRtpTransceiver.https.html
@@ -538,17 +538,17 @@
     t.add_cleanup(() => pc1.close());
     t.add_cleanup(() => pc2.close());
     pc1.addTransceiver("audio");
     pc2.addTransceiver("audio");
 
     const stream = await getNoiseStream({audio: true});
     t.add_cleanup(() => stopTracks(stream));
     const track = stream.getAudioTracks()[0];
-    pc2.getTransceivers()[0].sender.replaceTrack(track);
+    await pc2.getTransceivers()[0].sender.replaceTrack(track);
 
     const offer = await pc1.createOffer();
     const trackEvents = await setRemoteDescriptionReturnTrackEvents(pc2, offer);
     hasProps(trackEvents,
       [
         {
           track: pc2.getTransceivers()[1].receiver.track,
           streams: []
@@ -625,17 +625,17 @@
     t.add_cleanup(() => pc1.close());
     t.add_cleanup(() => pc2.close());
     pc1.addTransceiver("audio");
 
     const stream = await getNoiseStream({audio: true});
     t.add_cleanup(() => stopTracks(stream));
     const track = stream.getAudioTracks()[0];
     pc2.addTrack(track, stream);
-    pc2.getTransceivers()[0].sender.replaceTrack(null);
+    await pc2.getTransceivers()[0].sender.replaceTrack(null);
 
     const offer = await pc1.createOffer();
     const trackEvents = await setRemoteDescriptionReturnTrackEvents(pc2, offer);
     hasProps(trackEvents,
       [
         {
           track: pc2.getTransceivers()[0].receiver.track,
           streams: []