Bug 1176415: verify absence of SSRC's in data channel m-sections. r=bwc
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Thu, 01 Jun 2017 11:29:07 -0700
changeset 410067 4ec75a4481fc93a2b1c25eb199ab2e8a2544e7e4
parent 410066 12fa2783b2cc4639b35834418ca143740db5eec8
child 410068 8fdb9e30b6a77b46cf81232bcff642d939f7aa51
push id7391
push usermtabara@mozilla.com
push dateMon, 12 Jun 2017 13:08:53 +0000
treeherdermozilla-beta@2191d7f87e2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbwc
bugs1176415
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1176415: verify absence of SSRC's in data channel m-sections. r=bwc MozReview-Commit-ID: ADstE36mzzu
media/webrtc/signaling/gtest/jsep_session_unittest.cpp
--- a/media/webrtc/signaling/gtest/jsep_session_unittest.cpp
+++ b/media/webrtc/signaling/gtest/jsep_session_unittest.cpp
@@ -562,16 +562,21 @@ protected:
           std::string msidAttr("a=msid:");
           msidAttr += tracks[i]->GetStreamId();
           msidAttr += " ";
           msidAttr += tracks[i]->GetTrackId();
           ASSERT_NE(std::string::npos, offer.find(msidAttr))
             << "Did not find " << msidAttr << " in offer";
         }
       }
+      if (types.size() == 1 &&
+          tracks[0]->GetMediaType() == SdpMediaSection::kApplication) {
+        ASSERT_EQ(std::string::npos, offer.find("a=ssrc"))
+          << "Data channel should not contain SSRC";
+      }
     }
   }
 
   void
   SetRemoteOffer(const std::string& offer, uint32_t checkFlags = ALL_CHECKS)
   {
     nsresult rv = mSessionAns.SetRemoteDescription(kJsepSdpOffer, offer);
 
@@ -627,16 +632,21 @@ protected:
           std::string msidAttr("a=msid:");
           msidAttr += pairs[i].mSending->GetStreamId();
           msidAttr += " ";
           msidAttr += pairs[i].mSending->GetTrackId();
           ASSERT_NE(std::string::npos, answer.find(msidAttr))
             << "Did not find " << msidAttr << " in offer";
         }
       }
+      if (types.size() == 1 &&
+          pairs[0].mReceiving->GetMediaType() == SdpMediaSection::kApplication) {
+        ASSERT_EQ(std::string::npos, answer.find("a=ssrc"))
+          << "Data channel should not contain SSRC";
+      }
     }
     std::cerr << "OFFER pairs:" << std::endl;
     DumpTrackPairs(mSessionOff);
   }
 
   void
   SetRemoteAnswer(const std::string& answer, uint32_t checkFlags = ALL_CHECKS)
   {