Bug 817349 - Ensure topFrame is always defined; r=ted a=test-only
authorEd Morley <emorley@mozilla.com>
Mon, 03 Dec 2012 14:30:35 +0000
changeset 122232 4eba50f86632b2dd28a0057786e51796bb162dcb
parent 122231 978b4f46db49bed5b4dea44b518af13a87aa6cc8
child 122233 7ed48052d27e1379aa2c43c9dc0aab1559e8c646
push id1997
push userakeybl@mozilla.com
push dateMon, 07 Jan 2013 21:25:26 +0000
treeherdermozilla-beta@4baf45cdcf21 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted, test-only
bugs817349
milestone19.0a2
Bug 817349 - Ensure topFrame is always defined; r=ted a=test-only
build/automationutils.py
--- a/build/automationutils.py
+++ b/build/automationutils.py
@@ -162,16 +162,17 @@ def checkForCrashes(dumpDir, symbolsPath
     symbolsPath = tempfile.mkdtemp()
     zfile = ZipFileReader(symbolsFile)
     zfile.extractall(symbolsPath)
 
   try:
     for d in dumps:
       stackwalkOutput = []
       stackwalkOutput.append("Crash dump filename: " + d)
+      topFrame = None
       if symbolsPath and stackwalkPath and os.path.exists(stackwalkPath):
         # run minidump stackwalk
         p = subprocess.Popen([stackwalkPath, d, symbolsPath],
                              stdout=subprocess.PIPE,
                              stderr=subprocess.PIPE)
         (out, err) = p.communicate()
         if len(out) > 3:
           # minidump_stackwalk is chatty, so ignore stderr when it succeeds.