Bug 554957 - No hint of what each field does in the 'Add a new preference' feature [r=mark.finkle]
authorVivien Nicolas <21@vingtetun.org>
Thu, 25 Mar 2010 13:26:07 -0400
changeset 66063 4e83c7829c39566ee161d499abad5083a0355c5e
parent 66062 241ab7a30820096db3ca2ac8bbbbff7255376332
child 66064 ae996cba7d6cb0d207194e5744283547f55be075
push id1
push userroot
push dateTue, 26 Apr 2011 22:38:44 +0000
treeherdermozilla-beta@bfdb6e623a36 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmark
bugs554957
Bug 554957 - No hint of what each field does in the 'Add a new preference' feature [r=mark.finkle]
mobile/chrome/content/config.xul
mobile/locales/en-US/chrome/config.dtd
mobile/themes/hildon/config.css
mobile/themes/wince/config.css
--- a/mobile/chrome/content/config.xul
+++ b/mobile/chrome/content/config.xul
@@ -72,18 +72,18 @@
                 <button label="&integer.label;" oncommand="ViewConfig.open(Components.interfaces.nsIPrefBranch.PREF_INT)"/>
                 <button label="&boolean.label;" oncommand="ViewConfig.open(Components.interfaces.nsIPrefBranch.PREF_BOOL)"/>
                 <button label="&string.label;" oncommand="ViewConfig.open(Components.interfaces.nsIPrefBranch.PREF_STRING)"/>
               </hbox>
             </hbox>
 
             <vbox id="editor" hidden="true">
               <hbox align="center">
-                <textbox id="editor-name" flex="1"/>
-                <setting id="editor-setting" onlabel="true" offlabel="false" flex="1"/>
+                <textbox id="editor-name" emptytext="&addpref.name;" flex="1"/>
+                <setting id="editor-setting" emptytext="&addpref.value;" onlabel="true" offlabel="false" flex="1"/>
               </hbox>
               <hbox id="editor-buttons">
                 <button id="editor-cancel" label="&cancel.label;" oncommand="ViewConfig.close(false)"/>
                 <spacer flex="1"/>
                 <button id="editor-reset" label="&reset.label;" oncommand="ViewConfig.reset(this.parentNode.parentNode.nextSibling)"/>
                 <button id="editor-done" label="&done.label;" oncommand="ViewConfig.close(true)"/>
               </hbox>
             </vbox>
--- a/mobile/locales/en-US/chrome/config.dtd
+++ b/mobile/locales/en-US/chrome/config.dtd
@@ -1,10 +1,12 @@
 <!ENTITY empty.label            "Search">
-<!ENTITY newpref.label          "Add a new preference">
+<!ENTITY newpref.label          "Add a New Preference">
+<!ENTITY addpref.name           "Name">
+<!ENTITY addpref.value          "Value">
 
 <!ENTITY cancel.label           "Cancel">
 <!ENTITY reset.label            "Reset">
 <!ENTITY done.label             "Done">
 
 <!ENTITY integer.label          "Integer">
 <!ENTITY string.label           "String">
 <!ENTITY boolean.label          "Boolean">
--- a/mobile/themes/hildon/config.css
+++ b/mobile/themes/hildon/config.css
@@ -70,17 +70,17 @@ richlistitem .prefvalue {
 #editor > hbox > #editor-cancel,
 #editor > hbox > #editor-done {
   display: none;
 }
 
 #editor-container > #editor > hbox > #editor-name,
 #editor-container > #editor > hbox > #editor-cancel,
 #editor-container > #editor > hbox > #editor-done {
-  display: block;
+  display: -moz-box;
 }
 
 #editor-container > #editor > hbox > #editor-reset {
   display: none;
 }
 
 #editor + richlistitem {
   display: none;
--- a/mobile/themes/wince/config.css
+++ b/mobile/themes/wince/config.css
@@ -70,17 +70,17 @@ richlistitem .prefvalue {
 #editor > hbox > #editor-cancel,
 #editor > hbox > #editor-done {
   display: none;
 }
 
 #editor-container > #editor > hbox > #editor-name,
 #editor-container > #editor > hbox > #editor-cancel,
 #editor-container > #editor > hbox > #editor-done {
-  display: block;
+  display: -moz-box;
 }
 
 #editor-container > #editor > hbox > #editor-reset {
   display: none;
 }
 
 #editor + richlistitem {
   display: none;