Bug 1152331 - If we do not delete indices array, it gets picked up down the line and breaks some assumptions in aboutSupport.js. r=dvander, a=sledru
authorMilan Sreckovic <milan@mozilla.com>
Thu, 09 Apr 2015 10:44:17 -0400
changeset 258475 4cc36a9a958b
parent 258474 f5d0342230c0
child 258476 1412c445ff0d
push id4676
push userryanvm@gmail.com
push date2015-04-15 02:06 +0000
treeherdermozilla-beta@91df81e2edac [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdvander, sledru
bugs1152331
milestone38.0
Bug 1152331 - If we do not delete indices array, it gets picked up down the line and breaks some assumptions in aboutSupport.js. r=dvander, a=sledru
toolkit/content/aboutSupport.js
--- a/toolkit/content/aboutSupport.js
+++ b/toolkit/content/aboutSupport.js
@@ -194,25 +194,26 @@ let snapshotFormatters = {
             if (a.index < b.index) return -1;
             if (a.index > b.index) return 1;
             return 0;});
         $.append($("graphics-failures-tbody"),
                  combined.map(function(val) {
                    return $.new("tr", [$.new("th", val.header, "column"),
                                        $.new("td", val.message)]);
                  }));
+        delete data.indices;
       } else {
         $.append($("graphics-failures-tbody"),
           [$.new("tr", [$.new("th", "LogFailure", "column"),
                         $.new("td", data.failures.map(function (val) {
                           return $.new("p", val);
                        }))])]);
       }
 
-	delete data.failures;
+      delete data.failures;
     }
 
     // graphics-tbody tbody
 
     function localizedMsg(msgArray) {
       let nameOrMsg = msgArray.shift();
       if (msgArray.length) {
         // formatStringFromName logs an NS_ASSERTION failure otherwise that says