Bug 1421807: Add an assertion that should help with catching more instances of this bug. r=me
authorEmilio Cobos Álvarez <emilio@crisal.io>
Mon, 23 Apr 2018 21:28:01 +0200
changeset 468719 4ca67a1ab5b2e8a191caeb19ec09b07b7c42849e
parent 468703 45c6f888c2acabcc8076ce8220e0993f2aee88df
child 468720 7ce50d118d22a3a27be3b5761d05c7bb5d3d8c1a
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1421807
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1421807: Add an assertion that should help with catching more instances of this bug. r=me MozReview-Commit-ID: KSLF6GbKHRQ
layout/base/RestyleManager.cpp
--- a/layout/base/RestyleManager.cpp
+++ b/layout/base/RestyleManager.cpp
@@ -2587,16 +2587,18 @@ RestyleManager::ProcessPostTraversal(
   Element* aElement,
   ComputedStyle* aParentContext,
   ServoRestyleState& aRestyleState,
   ServoPostTraversalFlags aFlags)
 {
   nsIFrame* styleFrame = nsLayoutUtils::GetStyleFrame(aElement);
   nsIFrame* primaryFrame = aElement->GetPrimaryFrame();
 
+  MOZ_ASSERT(aElement->HasServoData(), "How in the world?");
+
   // NOTE(emilio): This is needed because for table frames the bit is set on the
   // table wrapper (which is the primary frame), not on the table itself.
   const bool isOutOfFlow =
     primaryFrame &&
     primaryFrame->HasAnyStateBits(NS_FRAME_OUT_OF_FLOW);
 
   // Grab the change hint from Servo.
   bool wasRestyled;