Bug 1423453 - Remove -moz-border-*-colors where possible. r=dao
authorRichard Marti <richard.marti@gmail.com>
Fri, 15 Dec 2017 13:38:49 +0100
changeset 448286 4b8c60ce984e2ad0b69ac72fc969f1de32c389df
parent 448222 6d82e132348fbe33cf3eb7c85c485083c50c6bb9
child 448287 4c3feee4dfd2d0efac06bf03c872cffd6f89ddc9
push id8527
push userCallek@gmail.com
push dateThu, 11 Jan 2018 21:05:50 +0000
treeherdermozilla-beta@95342d212a7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1423453
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1423453 - Remove -moz-border-*-colors where possible. r=dao MozReview-Commit-ID: JbvngOk18dR
browser/themes/windows/browser.css
toolkit/themes/osx/global/listbox.css
toolkit/themes/osx/global/tree.css
toolkit/themes/windows/global/autocomplete.css
toolkit/themes/windows/global/listbox.css
toolkit/themes/windows/global/menulist.css
toolkit/themes/windows/global/popup.css
toolkit/themes/windows/global/splitter.css
toolkit/themes/windows/global/tree.css
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -1164,24 +1164,16 @@ panel[touchmode] .PanelUI-subView #appMe
 .webextension-popup-stack {
   border-radius: inherit;
 }
 
 .contentSelectDropdown-ingroup > .menu-iconic-text {
   padding-inline-start: 20px;
 }
 
-#ContentSelectDropdown > menupopup {
-  background-color: -moz-field;
-  -moz-border-top-colors: GrayText;
-  -moz-border-right-colors: GrayText;
-  -moz-border-bottom-colors: GrayText;
-  -moz-border-left-colors: GrayText;
-}
-
 #ContentSelectDropdown > menupopup > menucaption,
 #ContentSelectDropdown > menupopup > menuitem {
   padding: 0 6px;
   border-width: 0;
   font: -moz-list;
 }
 
 #ContentSelectDropdown > menupopup > menucaption > .menu-iconic-text,
--- a/toolkit/themes/osx/global/listbox.css
+++ b/toolkit/themes/osx/global/listbox.css
@@ -24,45 +24,31 @@ listitem {
   border: 1px solid transparent;
 }
 
 listitem[selected="true"] {
   background-color: -moz-mac-secondaryhighlight;
   color: -moz-DialogText;
 }
 
-listbox:focus > listitem[selected="true"] {  
+listbox:focus > listitem[selected="true"] {
    background-color: Highlight;
    color: HighlightText;
 }
 
 /* ::::: listheader ::::: */
 
-listheader { 
+listheader {
   -moz-appearance: treeheadercell;
   -moz-box-align: center;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
-  background-color: -moz-Dialog;
   color: -moz-DialogText;
   padding: 0 4px;
 }
 
 listheader[sortable="true"]:hover:active {
-  border-top: 2px solid;
-  border-right: 1px solid;
-  border-bottom: 1px solid;
-  border-left: 2px solid;
-  -moz-border-top-colors: ThreeDShadow -moz-Dialog;
-  -moz-border-right-colors: ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDShadow;
-  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
   padding-top: 1px;
   padding-inline-start: 5px;
   padding-inline-end: 4px;
 }
 
 .listheader-icon {
   margin-inline-end: 2px;
 }
--- a/toolkit/themes/osx/global/tree.css
+++ b/toolkit/themes/osx/global/tree.css
@@ -162,76 +162,39 @@ treechildren::-moz-tree-cell-text(progre
 
 /* ::::: tree columns ::::: */
 
 treecol,
 treecolpicker {
   -moz-appearance: treeheadercell;
   -moz-box-align: center;
   -moz-box-pack: center;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
-  background-color: -moz-Dialog;
   color: -moz-DialogText;
-  padding: 0px 4px;
+  padding: 0 4px;
 }
 
 .treecol-image {
-  padding: 0px 1px;
+  padding: 0 1px;
 }
 
 .treecol-text {
-  margin: 0px !important;
+  margin: 0 !important;
 }
 
 treecol[hideheader="true"] {
   -moz-appearance: none;
   border: none;
   padding: 0;
-  max-height: 0px;
-}
-
-/* ..... internal box ..... */
-
-treecol:hover:active,
-treecolpicker:hover:active {
-  border-top: 2px solid;
-  border-bottom: 1px solid;
-  border-inline-start: 2px solid;
-  border-inline-end: 1px solid;
-  -moz-border-top-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-right-colors: ThreeDDarkShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow;
-  -moz-border-left-colors: ThreeDDarkShadow ThreeDShadow;
-  background-color: #666666;
+  max-height: 0;
 }
 
 /* ::::: column drag and drop styles ::::: */
 
 treecol[dragging="true"] {
-  -moz-border-top-colors: ThreeDDarkShadow ThreeDShadow !important;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow!important;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow !important;
-  -moz-border-left-colors: ThreeDDarkShadow ThreeDShadow !important;
-  padding: 0px 4px !important;
-  background-color: ThreeDShadow !important;
-  color: ThreeDHighlight !important;
-}
-
-treecol[insertafter="true"]:-moz-locale-dir(ltr),
-treecol[insertbefore="true"]:-moz-locale-dir(rtl) {
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-}
-
-treecol[insertafter="true"]:-moz-locale-dir(rtl),
-treecol[insertbefore="true"]:-moz-locale-dir(ltr) {
-  -moz-border-left-colors: ThreeDDarkShadow ThreeDShadow;
+  color: GrayText;
 }
 
 treechildren::-moz-tree-column(insertbefore) {
   border-inline-start: 1px solid ThreeDShadow;
 }
 
 treechildren::-moz-tree-column(insertafter) {
   border-inline-end: 1px solid ThreeDShadow;
--- a/toolkit/themes/windows/global/autocomplete.css
+++ b/toolkit/themes/windows/global/autocomplete.css
@@ -16,21 +16,16 @@ textbox[nomatch="true"][highlightnonmatc
 }
 
 /* ::::: autocomplete popups ::::: */
 
 panel[type="autocomplete"],
 panel[type="autocomplete-richlistbox"],
 .autocomplete-history-popup {
   -moz-appearance: none;
-  border-width: 1px;
-  -moz-border-top-colors: ThreeDShadow;
-  -moz-border-right-colors: ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDShadow;
-  -moz-border-left-colors: ThreeDShadow;
   padding: 0;
   color: -moz-FieldText;
   background-color: -moz-Field;
 }
 
 .autocomplete-history-popup {
   max-height: 180px;
 }
--- a/toolkit/themes/windows/global/listbox.css
+++ b/toolkit/themes/windows/global/listbox.css
@@ -9,22 +9,16 @@
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* ::::: listbox ::::: */
 
 listbox {
   -moz-appearance: listbox;
   margin: 2px 4px;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDShadow ThreeDDarkShadow;
-  -moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
-  background-color: -moz-Field;
   color: -moz-FieldText;
 }
 
 listbox[disabled="true"] {
   color: GrayText;
 }
 
 /* ::::: listitem ::::: */
@@ -52,35 +46,21 @@ listbox:focus > listitem[selected="true"
   color: HighlightText;
 }
 
 /* ::::: listheader ::::: */
 
 listheader {
   -moz-appearance: treeheadercell;
   -moz-box-align: center;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
-  background-color: -moz-Dialog;
   color: -moz-DialogText;
   padding: 0 4px;
 }
 
 listheader[sortable="true"]:hover:active {
-  border-top: 2px solid;
-  border-right: 1px solid;
-  border-bottom: 1px solid;
-  border-left: 2px solid;
-  -moz-border-top-colors: ThreeDShadow -moz-Dialog;
-  -moz-border-right-colors: ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDShadow;
-  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
   padding-top: 1px;
   padding-bottom: 0px;
   padding-inline-start: 5px;
   padding-inline-end: 4px;
 }
 
 .listheader-icon {
   margin-inline-end: 2px;
--- a/toolkit/themes/windows/global/menulist.css
+++ b/toolkit/themes/windows/global/menulist.css
@@ -9,22 +9,16 @@
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 @namespace html url("http://www.w3.org/1999/xhtml");
 
 /* :::::::::: menulist :::::::::: */
 
 menulist {
   -moz-appearance: menulist;
   margin: 2px 4px;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDShadow ThreeDDarkShadow;
-  -moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
-  background-color: -moz-Field;
   color: -moz-FieldText;
   text-shadow: none;
 }
 
 .menulist-label-box {
   -moz-box-align: center;
   -moz-box-pack: center;
   margin: 1px;
@@ -45,37 +39,16 @@ menulist {
 }
 
 .menulist-description {
   font-style: italic;
   color: GrayText;
   margin-inline-start: 1ex !important;
 }
 
-/* ..... dropmarker ..... */
-
-menulist[disabled="true"]:hover:active > .menulist-dropmarker {
-  -moz-border-top-colors: ThreeDLightShadow ThreeDHighlight;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-left-colors: ThreeDLightShadow ThreeDHighlight;
-  padding: 1px;
-}
-
-menulist:hover:active > .menulist-dropmarker {
-  -moz-border-top-colors: ThreeDShadow ThreeDFace;
-  -moz-border-right-colors: ThreeDShadow ThreeDFace;
-  -moz-border-bottom-colors: ThreeDShadow ThreeDFace;
-  -moz-border-left-colors: ThreeDShadow ThreeDFace;
-  padding-top: 2px;
-  padding-bottom: 0px;
-  padding-inline-start: 2px;
-  padding-inline-end: 0px;
-}
-
 /* ..... focused state ..... */
 
 menulist:focus:not([open="true"]) > .menulist-label-box {
   background-color: Highlight;
   color: HighlightText;
 }
 
 menulist:-moz-focusring:not([open="true"]) > .menulist-label-box {
--- a/toolkit/themes/windows/global/popup.css
+++ b/toolkit/themes/windows/global/popup.css
@@ -3,22 +3,18 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* ::::: menupopup ::::: */
 
 menupopup,
 panel {
-  border: 3px solid transparent;
-  -moz-border-top-colors   : ThreeDLightShadow ThreeDHighlight ThreeDFace;
-  -moz-border-left-colors  : ThreeDLightShadow ThreeDHighlight ThreeDFace;
-  -moz-border-right-colors : ThreeDDarkShadow  ThreeDShadow    ThreeDFace;
-  -moz-border-bottom-colors: ThreeDDarkShadow  ThreeDShadow    ThreeDFace;
-  padding: 0px;
+  border: 1px solid ThreeDShadow;
+  padding: 0;
   min-width: 1px;
   background: Menu;
   color: MenuText;
 }
 
 menupopup {
   -moz-appearance: menupopup;
 }
@@ -141,17 +137,11 @@ tooltip[titletip="true"] {
   */
   max-width: none;
 }
 
 /* rules for popups associated with menulists */
 
 menulist > menupopup {
   -moz-appearance: none;
-  border-width: 1px;
-  -moz-border-top-colors: -moz-FieldText;
-  -moz-border-right-colors: -moz-FieldText;
-  -moz-border-bottom-colors: -moz-FieldText;
-  -moz-border-left-colors: -moz-FieldText;
-  padding: 0px;
-  min-width: 0px;
+  min-width: 0;
   background-color: -moz-Field;
 }
--- a/toolkit/themes/windows/global/splitter.css
+++ b/toolkit/themes/windows/global/splitter.css
@@ -9,20 +9,20 @@
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* ::::: splitter (vertical) ::::: */
 
 splitter {
   -moz-box-align: center;
   -moz-box-pack: center;
   cursor: ew-resize;
-  border-width: 0 2px;
+  border-width: 0 1px;
   border-style: solid;
-  -moz-border-left-colors: ThreeDShadow ThreeDHighlight;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDFace;
+  border-inline-start-color: ThreeDHighlight;
+  border-inline-end-color: ThreeDShadow;
   min-width: 6px;
   background-color: ThreeDFace;
 }
 
 splitter[state="collapsed"][collapse="before"],
 splitter[state="collapsed"][substate="before"],
 splitter[state="collapsed"][collapse="after"]:-moz-locale-dir(rtl),
 splitter[state="collapsed"][substate="after"]:-moz-locale-dir(rtl) {
@@ -39,19 +39,19 @@ splitter[state="collapsed"][substate="be
 splitter:-moz-lwtheme {
   background: none;
 }
 
 /* ::::: splitter (horizontal) ::::: */
 
 splitter[orient="vertical"] {
   cursor: ns-resize;
-  border-width: 2px 0;
-  -moz-border-top-colors: ThreeDShadow ThreeDHighlight;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDFace;
+  border-width: 1px 0;
+  border-top-color: ThreeDHighlight;
+  border-bottom-color: ThreeDShadow;
   min-height: 6px;
 }
 
 splitter[orient="vertical"][state="collapsed"][collapse="before"],
 splitter[orient="vertical"][state="collapsed"][substate="before"] {
   cursor: s-resize;
 }
 
@@ -83,53 +83,53 @@ grippy:hover {
 splitter[orient="vertical"] > grippy {
   border-top: none;
   border-right: 1px solid ThreeDShadow;
   border-bottom: none;
   border-left: 1px solid ThreeDShadow;;
   min-width: 115px;
   min-height: 4px;
 }
-  
+
 /* ..... normal state ..... */
 
 /* vertical grippies */
 splitter[collapse="before"] > grippy,
 splitter[collapse="after"] > grippy:-moz-locale-dir(rtl) {
   background-image: url("chrome://global/skin/splitter/grip-left.gif");
 }
 
 splitter[collapse="after"] > grippy,
 splitter[collapse="before"] > grippy:-moz-locale-dir(rtl) {
   background-image: url("chrome://global/skin/splitter/grip-right.gif");
 }
 
 /* horizontal grippies */
 splitter[collapse="before"][orient="vertical"] > grippy {
   background-image: url("chrome://global/skin/splitter/grip-top.gif");
-}  
+}
 
 splitter[collapse="after"][orient="vertical"] > grippy {
   background-image: url("chrome://global/skin/splitter/grip-bottom.gif");
-}  
-  
+}
+
 /* ..... collapsed state ..... */
 
 /* vertical grippies */
 splitter[collapse="before"][state="collapsed"] > grippy,
 splitter[collapse="after"][state="collapsed"] > grippy:-moz-locale-dir(rtl) {
   background-image: url("chrome://global/skin/splitter/grip-right.gif");
 }
 
 splitter[collapse="after"][state="collapsed"] > grippy,
 splitter[collapse="before"][state="collapsed"] > grippy:-moz-locale-dir(rtl) {
   background-image: url("chrome://global/skin/splitter/grip-left.gif");
 }
 
 /* horizontal grippies */
 splitter[collapse="before"][state="collapsed"][orient="vertical"] > grippy {
   background-image: url("chrome://global/skin/splitter/grip-bottom.gif");
-}  
+}
 
 splitter[collapse="after"][state="collapsed"][orient="vertical"] > grippy {
   background-image: url("chrome://global/skin/splitter/grip-top.gif");
-}  
+}
 
--- a/toolkit/themes/windows/global/tree.css
+++ b/toolkit/themes/windows/global/tree.css
@@ -6,22 +6,17 @@
   == Styles used by the XUL outline element.
   ======================================================================= */
 
 @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
 
 /* ::::: tree ::::: */
 
 tree {
-  margin: 0px 4px;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDShadow ThreeDDarkShadow;
-  -moz-border-right-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-bottom-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-left-colors: ThreeDShadow ThreeDDarkShadow;
+  margin: 0 4px;
   background-color: -moz-Field;
   color: -moz-FieldText;
   -moz-appearance: listbox;
 }
 
 /* ::::: tree focusring ::::: */
 
 .focusring > .tree-stack > .tree-rows > .tree-bodybox {
@@ -62,17 +57,17 @@ tree[seltype="text"] > treechildren::-mo
   border: none;
   background-color: transparent;
   background-image: none;
 }
 
 /* ::::: tree cells ::::: */
 
 treechildren::-moz-tree-cell {
-  padding: 0px 2px 0px 2px;
+  padding: 0 2px;
 }
 
 tree[seltype="cell"] > treechildren::-moz-tree-cell-text,
 tree[seltype="text"] > treechildren::-moz-tree-cell-text,
 treechildren::-moz-tree-cell-text {
   color: inherit;
 }
 
@@ -198,82 +193,55 @@ treechildren::-moz-tree-cell-text(progre
 
 /* ::::: tree columns ::::: */
 
 treecol,
 treecolpicker {
   -moz-appearance: treeheadercell;
   -moz-box-align: center;
   -moz-box-pack: center;
-  border: 2px solid;
-  -moz-border-top-colors: ThreeDHighlight ThreeDLightShadow;
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDDarkShadow ThreeDShadow;
-  -moz-border-left-colors: ThreeDHighlight ThreeDLightShadow;
-  background-color: -moz-Dialog;
   color: -moz-DialogText;
-  padding: 0px 4px;
+  padding: 0 4px;
 }
 
 .treecol-image {
-  padding: 0px 1px;
+  padding: 0 1px;
 }
 
 .treecol-text {
-  margin: 0px !important;
+  margin: 0 !important;
 }
 
 treecol[hideheader="true"] {
   -moz-appearance: none;
   border: none;
   padding: 0;
 }
 
 /* ..... internal box ..... */
 
 treecol:hover:active,
 treecolpicker:hover:active {
-  border-top: 2px solid;
-  border-bottom: 1px solid;
-  -moz-border-top-colors: ThreeDShadow -moz-Dialog;
-  -moz-border-right-colors: ThreeDShadow;
-  -moz-border-bottom-colors: ThreeDShadow;
-  -moz-border-left-colors: ThreeDShadow -moz-Dialog;
   padding-top: 1px;
-  padding-bottom: 0px;
+  padding-bottom: 0;
   padding-inline-start: 5px;
   padding-inline-end: 3px;
 }
 
 .treecol-image:hover:active {
   padding-top: 1px;
-  padding-bottom: 0px;
+  padding-bottom: 0;
   padding-inline-start: 2px;
-  padding-inline-end: 0px;
+  padding-inline-end: 0;
 }
 
 /* ::::: column drag and drop styles ::::: */
 
 treecol[dragging="true"] {
-  -moz-border-top-colors: ThreeDDarkShadow transparent !important;
-  -moz-border-right-colors: ThreeDDarkShadow transparent!important;
-  -moz-border-bottom-colors: ThreeDDarkShadow transparent !important;
-  -moz-border-left-colors: ThreeDDarkShadow transparent !important;
-  background-color: ThreeDShadow !important;
-  color: ThreeDHighlight !important;
-}
-
-treecol[insertafter="true"]:-moz-locale-dir(ltr),
-treecol[insertbefore="true"]:-moz-locale-dir(rtl) {
-  -moz-border-right-colors: ThreeDDarkShadow ThreeDShadow;
-}
-
-treecol[insertafter="true"]:-moz-locale-dir(rtl),
-treecol[insertbefore="true"]:-moz-locale-dir(ltr) {
-  -moz-border-left-colors: ThreeDDarkShadow ThreeDShadow;
+  color: GrayText;
 }
 
 treechildren::-moz-tree-column(insertbefore) {
   border-inline-start: 1px solid ThreeDShadow;
 }
 
 treechildren::-moz-tree-column(insertafter) {
   border-inline-end: 1px solid ThreeDShadow;