Bug 1299812 - Remove unused mFilename member of mozilla::dom::Exception. r=bkelly
authorMs2ger <Ms2ger@gmail.com>
Thu, 01 Sep 2016 16:26:15 +0200
changeset 354437 4b1be484aab80b6029608e6a25002537f6690da7
parent 354436 074f9de56ac0420e644b2bab7cade77d736d67b9
child 354438 7cd3bccd9cfef1b8f8feff8dee413b5341f012c2
push id6570
push userraliiev@mozilla.com
push dateMon, 14 Nov 2016 12:26:13 +0000
treeherdermozilla-beta@f455459b2ae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbkelly
bugs1299812
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1299812 - Remove unused mFilename member of mozilla::dom::Exception. r=bkelly
dom/base/DOMException.cpp
dom/base/DOMException.h
--- a/dom/base/DOMException.cpp
+++ b/dom/base/DOMException.cpp
@@ -311,17 +311,17 @@ NS_IMETHODIMP
 Exception::GetFilename(JSContext* aCx, nsAString& aFilename)
 {
   NS_ENSURE_TRUE(mInitialized, NS_ERROR_NOT_INITIALIZED);
 
   if (mLocation) {
     return mLocation->GetFilename(aCx, aFilename);
   }
 
-  aFilename.Assign(mFilename);
+  aFilename.Truncate();
   return NS_OK;
 }
 
 NS_IMETHODIMP
 Exception::GetLineNumber(JSContext* aCx, uint32_t *aLineNumber)
 {
   NS_ENSURE_ARG_POINTER(aLineNumber);
   NS_ENSURE_TRUE(mInitialized, NS_ERROR_NOT_INITIALIZED);
--- a/dom/base/DOMException.h
+++ b/dom/base/DOMException.h
@@ -131,17 +131,16 @@ protected:
     }
   }
 
   nsCString       mMessage;
   nsresult        mResult;
   nsCString       mName;
   nsCOMPtr<nsIStackFrame> mLocation;
   nsCOMPtr<nsISupports> mData;
-  nsString        mFilename;
   int             mLineNumber;
   bool            mInitialized;
 
   bool mHoldingJSVal;
   JS::Heap<JS::Value> mThrownJSVal;
 
 private:
   static bool sEverMadeOneFromFactory;