Bug 802456. Make all popup type windows on Windows have the composited style to work around a bug in Windows. r=jimm a=bajaj
☠☠ backed out by fd8361463029 ☠ ☠
authorTimothy Nikkel <tnikkel@gmail.com>
Sat, 20 Oct 2012 16:05:14 -0500
changeset 116323 4af749bc6e826637d8fe2ee74b522efb2cfa6c7e
parent 116322 b100957a878e4d49c3718b5e2c4f3197fbe6d83a
child 116324 ce80f2d6cd436136b5c88ebff973db834489c7bb
push id1708
push userakeybl@mozilla.com
push dateMon, 19 Nov 2012 21:10:21 +0000
treeherdermozilla-beta@27b14fe50103 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimm, bajaj
bugs802456
milestone18.0a2
Bug 802456. Make all popup type windows on Windows have the composited style to work around a bug in Windows. r=jimm a=bajaj
widget/windows/nsWindow.cpp
--- a/widget/windows/nsWindow.cpp
+++ b/widget/windows/nsWindow.cpp
@@ -480,18 +480,17 @@ nsWindow::Create(nsIWidget *aParent,
   DWORD style = WindowStyle();
   DWORD extendedStyle = WindowExStyle();
 
   if (mWindowType == eWindowType_popup) {
     if (!aParent) {
       parent = NULL;
     }
 
-    if (WinUtils::GetWindowsVersion() >= WinUtils::VISTA_VERSION &&
-        mPopupType == ePopupTypeMenu && aInitData->mDropShadow) {
+    if (WinUtils::GetWindowsVersion() >= WinUtils::VISTA_VERSION) {
       extendedStyle |= WS_EX_COMPOSITED;
     }
 
     if (aInitData->mIsDragPopup) {
       // This flag makes the window transparent to mouse events
       extendedStyle |= WS_EX_TRANSPARENT;
     }
   } else if (mWindowType == eWindowType_invisible) {