Bug 1453876: Fix accessibility blocking of the Ask.com Toolbar. r=eeejay
authorJames Teh <jteh@mozilla.com>
Fri, 13 Apr 2018 15:12:13 +1000
changeset 466970 4a34418e88ddda39ec7dfb0bc32e81ae46c852ee
parent 466969 7ff499dfcd51cf4a95ebf0db506b415bf7bb27c3
child 466971 bc6e8d505359dcfb67af363b572502070f13714b
push id9165
push userasasaki@mozilla.com
push dateThu, 26 Apr 2018 21:04:54 +0000
treeherdermozilla-beta@064c3804de2e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerseeejay
bugs1453876, 1421018
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1453876: Fix accessibility blocking of the Ask.com Toolbar. r=eeejay Bug 1421018 intended to block the Ask.Com Toolbar (tbnotifier.exe). This is basically malware and is responsible for a huge number of unnecessary accessibility instantiations. However, there seems to have been some confusion and we ended up blocking tbnnotifier.exe instead. This changes that block to tbnotifier.exe. MozReview-Commit-ID: 2gZF8sYeGtb
accessible/windows/msaa/LazyInstantiator.cpp
--- a/accessible/windows/msaa/LazyInstantiator.cpp
+++ b/accessible/windows/msaa/LazyInstantiator.cpp
@@ -190,17 +190,17 @@ static const DllBlockInfo gBlockedInproc
   {L"dtvhooks.dll", MAKE_FILE_VERSION(18, 1, 11, 0)},
   {L"dtvhooks64.dll", MAKE_FILE_VERSION(18, 1, 11, 0)}
 };
 
 /**
  * This is the blocklist for known "bad" remote clients that instantiate a11y.
  */
 static const char* gBlockedRemoteClients[] = {
-  "tbnnotifier.exe" // Ask.com Toolbar, bug 1421018
+  "tbnotifier.exe" // Ask.com Toolbar, bug 1453876
 };
 
 /**
  * Check for the presence of any known "bad" injected DLLs that may be trying
  * to instantiate a11y.
  *
  * @return true to block a11y instantiation, otherwise false to continue
  */