Bug 1529055 [wpt PR 15404] - Modify HTMLButtonElement CEReactions tests for boolean attributes, a=testonly
authorkaixinjxq <xiuqix.jiang@intel.com>
Tue, 05 Mar 2019 12:17:47 +0000
changeset 522470 49b20d703832f84944761ca959f005e50fc90011
parent 522469 c6d92a71240c37ee9715183bc35fa756c2091a82
child 522471 161e0f5c15160eb0be355322ae74b665f404a393
push id10871
push usercbrindusan@mozilla.com
push dateMon, 18 Mar 2019 15:49:32 +0000
treeherdermozilla-beta@018abdd16060 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1529055, 15404, 15167
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1529055 [wpt PR 15404] - Modify HTMLButtonElement CEReactions tests for boolean attributes, a=testonly Automatic update from web-platform-tests Fix HTMLButtonElement CEReactions tests for boolean attributes Closes #15167. -- wpt-commits: 02ccac44500d8b6011f1281e3496211f51a1f277 wpt-pr: 15404
testing/web-platform/tests/custom-elements/reactions/HTMLButtonElement.html
--- a/testing/web-platform/tests/custom-elements/reactions/HTMLButtonElement.html
+++ b/testing/web-platform/tests/custom-elements/reactions/HTMLButtonElement.html
@@ -11,25 +11,25 @@
 <script>
 
 function getParentElement(parentElementName) {
   let parentElement = document.createElement(parentElementName);
   document.body.appendChild(parentElement);
   return parentElement;
 }
 
-testReflectAttributeWithContentValues('autofocus', 'autofocus', true, 'true', false, 'false', 'autofocus on HTMLButtonElement', 'button', HTMLButtonElement);
-testReflectAttributeWithContentValues('disabled', 'disabled', true, 'true', false, 'false', 'disabled on HTMLButtonElement', 'button', HTMLButtonElement);
+testReflectBooleanAttribute('autofocus', 'autofocus', 'autofocus on HTMLButtonElement', 'button', HTMLButtonElement);
+testReflectBooleanAttribute('disabled', 'disabled', 'disabled on HTMLButtonElement', 'button', HTMLButtonElement);
 testReflectAttribute('name', 'name', 'intel', 'intel1', 'name on HTMLButtonElement', 'button', HTMLButtonElement);
 testReflectAttribute('value', 'value', 'HTML', 'CSS', 'value on HTMLButtonElement', 'button', HTMLButtonElement);
 testReflectAttributeWithParentNode('type', 'type', 'submit', 'reset', 'type on HTMLButtonElement', 'button', () => getParentElement('form'), HTMLButtonElement);
 testReflectAttrWithDepAttr('formAction', 'formaction', 'type', 'intel.asp', 'intel1.asp', 'submit', 'formAction on HTMLButtonElement', 'button', 'form', HTMLButtonElement);
 testReflectAttrWithDepAttr('formEnctype', 'formenctype', 'type', 'text/plain', 'multipart/form-data', 'submit', 'formEnctype on HTMLButtonElement', 'button', 'form', HTMLButtonElement);
 testReflectAttrWithDepAttr('formMethod', 'formmethod', 'type', 'get', 'post', 'submit', 'formMethod on HTMLButtonElement', 'button', 'form', HTMLButtonElement);
-testReflectAttrWithContentValuesAndDepAttr('formNoValidate', 'formnovalidate', 'type', true, 'true', false, 'false', 'submit', 'formNoValidate on HTMLButtonElement', 'button', 'form', HTMLButtonElement);
+testReflectAttrWithContentValuesAndDepAttr('formNoValidate', 'formnovalidate', 'type', true, '', false, null, 'submit', 'formNoValidate on HTMLButtonElement', 'button', 'form', HTMLButtonElement);
 testReflectAttrWithDepAttr('formTarget', 'formtarget', 'type', '_blank', '_self', 'submit', 'formTarget on HTMLButtonElement', 'button', 'form', HTMLButtonElement);
 
 //In parent node, sub node's observeAttribute which depends another attribute can enqueue by changing attribute value
 //Test reflect attribute with content values and dependent attribute 
 function testReflectAttrWithContentValuesAndDepAttr(jsAtName, coAtName, deAtName, jsAtValue1, coAtValue1, jsAtValue2, coAtValue2, deAtValue, name, elementName, pElementName, interfaceName) {
     var parentElement = document.createElement(pElementName);
     document.body.appendChild(parentElement);