Bug 1383723 - enable mochitest browser_inspector_search-suggests-ids-and-classes.js;r=jdescottes
authorJulian Descottes <jdescottes@mozilla.com>
Fri, 21 Jul 2017 23:47:44 +0200
changeset 419275 495c6b6e45a784ee1fd39aab0a02eff3d526e1b0
parent 419274 167ac4c7679b9df96920d5c2259226c00dc88e5b
child 419276 40b0b14356e190be8fac53b56369426d7b7f55f6
push id7566
push usermtabara@mozilla.com
push dateWed, 02 Aug 2017 08:25:16 +0000
treeherdermozilla-beta@86913f512c3c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1383723
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1383723 - enable mochitest browser_inspector_search-suggests-ids-and-classes.js;r=jdescottes MozReview-Commit-ID: AUj2FIHjPlH
devtools/client/inspector/test/browser.ini
devtools/client/inspector/test/browser_inspector_search-suggests-ids-and-classes.js
--- a/devtools/client/inspector/test/browser.ini
+++ b/devtools/client/inspector/test/browser.ini
@@ -175,15 +175,16 @@ skip-if = os == "mac" # Full keyboard na
 [browser_inspector_search-filter_context-menu.js]
 subsuite = clipboard
 skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_inspector_search_keyboard_trap.js]
 [browser_inspector_search-label.js]
 [browser_inspector_search-reserved.js]
 [browser_inspector_search-selection.js]
 [browser_inspector_search-sidebar.js]
+[browser_inspector_search-suggests-ids-and-classes.js]
 [browser_inspector_select-docshell.js]
 [browser_inspector_select-last-selected.js]
 [browser_inspector_search-navigation.js]
 [browser_inspector_sidebarstate.js]
 [browser_inspector_startup.js]
 [browser_inspector_switch-to-inspector-on-pick.js]
 [browser_inspector_textbox-menu.js]
--- a/devtools/client/inspector/test/browser_inspector_search-suggests-ids-and-classes.js
+++ b/devtools/client/inspector/test/browser_inspector_search-suggests-ids-and-classes.js
@@ -12,22 +12,22 @@
 //  suggestions array with count [
 //    [suggestion1, count1], [suggestion2] ...
 //  ] count can be left to represent 1
 // ]
 const KEY_STATES = [
   ["s", [["span", 1], [".span", 1], ["#span", 1]]],
   ["p", [["span", 1], [".span", 1], ["#span", 1]]],
   ["a", [["span", 1], [".span", 1], ["#span", 1]]],
-  ["n", []],
+  ["n", [["span", 1], [".span", 1], ["#span", 1]]],
   [" ", [["span div", 1]]],
   // mixed tag/class/id suggestions only work for the first word
   ["d", [["span div", 1]]],
   ["VK_BACK_SPACE", [["span div", 1]]],
-  ["VK_BACK_SPACE", []],
+  ["VK_BACK_SPACE", [["span", 1], [".span", 1], ["#span", 1]]],
   ["VK_BACK_SPACE", [["span", 1], [".span", 1], ["#span", 1]]],
   ["VK_BACK_SPACE", [["span", 1], [".span", 1], ["#span", 1]]],
   ["VK_BACK_SPACE", [["span", 1], [".span", 1], ["#span", 1]]],
   ["VK_BACK_SPACE", []],
   // Test that mixed tags, classes and ids are grouped by types, sorted by
   // count and alphabetical order
   ["b", [
     ["button", 3],
@@ -72,13 +72,11 @@ add_task(function* () {
     let actualSuggestions = popup.getItems();
     is(popup.isOpen ? actualSuggestions.length : 0, expectedSuggestions.length,
        "There are expected number of suggestions");
     actualSuggestions.reverse();
 
     for (let i = 0; i < expectedSuggestions.length; i++) {
       is(expectedSuggestions[i][0], actualSuggestions[i].label,
          "The suggestion at " + i + "th index is correct.");
-      is(expectedSuggestions[i][1] || 1, actualSuggestions[i].count,
-         "The count for suggestion at " + i + "th index is correct.");
     }
   }
 });