Bug 1514400 - Download minidump_stackwalk by default. r=ahal
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 21 Dec 2018 19:31:34 +0000
changeset 508877 48b059d9a1de4540d2ce9f92abf9eb058c188cf1
parent 508876 b723ef9caca92c5b4635f352671eafc2737a3735
child 508878 e8700e52f777b56af2c095d545fd084478bd9db5
push id10547
push userffxbld-merge
push dateMon, 21 Jan 2019 13:03:58 +0000
treeherdermozilla-beta@24ec1916bffe [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersahal
bugs1514400, 1513157
milestone66.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1514400 - Download minidump_stackwalk by default. r=ahal As of bug 1513157, minidump_stackwalk is not installed in the test docker images, so it needs to be downloaded. Differential Revision: https://phabricator.services.mozilla.com/D14644
testing/mozharness/configs/android/android_hw.py
testing/mozharness/configs/awsy/linux_config.py
testing/mozharness/configs/awsy/macosx_config.py
testing/mozharness/configs/awsy/taskcluster_windows_config.py
testing/mozharness/configs/firefox_ui_tests/qa_jenkins.py
testing/mozharness/configs/firefox_ui_tests/releng_release.py
testing/mozharness/configs/firefox_ui_tests/taskcluster.py
testing/mozharness/configs/firefox_ui_tests/taskcluster_windows.py
testing/mozharness/configs/marionette/prod_config.py
testing/mozharness/configs/marionette/windows_config.py
testing/mozharness/configs/marionette/windows_taskcluster_config.py
testing/mozharness/configs/raptor/android_hw_config.py
testing/mozharness/configs/raptor/linux64_config_taskcluster.py
testing/mozharness/configs/raptor/linux_config.py
testing/mozharness/configs/raptor/mac_config.py
testing/mozharness/configs/raptor/windows_config.py
testing/mozharness/configs/raptor/windows_vm_config.py
testing/mozharness/configs/talos/linux64_config_taskcluster.py
testing/mozharness/configs/talos/linux_config.py
testing/mozharness/configs/talos/mac_config.py
testing/mozharness/configs/talos/windows_config.py
testing/mozharness/configs/talos/windows_taskcluster_config.py
testing/mozharness/configs/talos/windows_vm_config.py
testing/mozharness/configs/unittests/linux_unittest.py
testing/mozharness/configs/unittests/mac_unittest.py
testing/mozharness/configs/unittests/win_taskcluster_unittest.py
testing/mozharness/configs/unittests/win_unittest.py
testing/mozharness/configs/web_platform_tests/prod_config.py
testing/mozharness/configs/web_platform_tests/prod_config_android.py
testing/mozharness/configs/web_platform_tests/prod_config_windows.py
testing/mozharness/configs/web_platform_tests/prod_config_windows_taskcluster.py
testing/mozharness/mozharness/mozilla/testing/testbase.py
--- a/testing/mozharness/configs/android/android_hw.py
+++ b/testing/mozharness/configs/android/android_hw.py
@@ -18,14 +18,13 @@ config = {
         'create-virtualenv',
         'verify-device',
         'install',
         'run-tests',
     ],
     "tooltool_cache": "/builds/tooltool_cache",
     # from android_common.py
     "download_tooltool": True,
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "linux64-minidump_stackwalk",
     "tooltool_servers": ['https://tooltool.mozilla-releng.net/'],
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/linux64/releng.manifest",
     "xpcshell_extra": "--remoteTestRoot=/data/local/tests",
 }
--- a/testing/mozharness/configs/awsy/linux_config.py
+++ b/testing/mozharness/configs/awsy/linux_config.py
@@ -25,13 +25,12 @@ config = {
     "default_actions": [
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": os.path.join(os.getcwd(), "tooltool_cache"),
 }
--- a/testing/mozharness/configs/awsy/macosx_config.py
+++ b/testing/mozharness/configs/awsy/macosx_config.py
@@ -18,13 +18,12 @@ config = {
     "default_actions": [
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": os.path.join(os.getcwd(), "tooltool_cache"),
 }
--- a/testing/mozharness/configs/awsy/taskcluster_windows_config.py
+++ b/testing/mozharness/configs/awsy/taskcluster_windows_config.py
@@ -9,17 +9,16 @@ external_tools_path = os.path.join(
 
 config = {
     "virtualenv_path": 'venv',
     "exes": {
         'python': sys.executable,
         'hg': os.path.join(os.environ['PROGRAMFILES'], 'Mercurial', 'hg')
     },
 
-    "download_minidump_stackwalk": True,
     "download_symbols": "ondemand",
 
     "default_actions": [
         'clobber',
         'download-and-extract',
         "populate-webroot",
         'create-virtualenv',
         'install',
--- a/testing/mozharness/configs/firefox_ui_tests/qa_jenkins.py
+++ b/testing/mozharness/configs/firefox_ui_tests/qa_jenkins.py
@@ -1,11 +1,10 @@
 # Default configuration as used by Mozmill CI (Jenkins)
 
 
 config = {
     # Tests run in mozmill-ci do not use RelEng infra
     'developer_mode': True,
 
     # mozcrash support
-    'download_minidump_stackwalk': True,
     'download_symbols': 'ondemand',
 }
--- a/testing/mozharness/configs/firefox_ui_tests/releng_release.py
+++ b/testing/mozharness/configs/firefox_ui_tests/releng_release.py
@@ -18,11 +18,10 @@ config = {
         'gittool.py': [
             # Bug 1227079 - Python executable eeded to get it executed on Windows
             sys.executable,
             os.path.join(external_tools_path, 'gittool.py')
         ],
     },
 
     # mozcrash support
-    'download_minidump_stackwalk': True,
     'download_symbols': 'ondemand',
 }
--- a/testing/mozharness/configs/firefox_ui_tests/taskcluster.py
+++ b/testing/mozharness/configs/firefox_ui_tests/taskcluster.py
@@ -1,9 +1,8 @@
 # Config file for firefox ui tests run via TaskCluster.
 
 
 config = {
     "vcs_share_base": "/builds/hg-shared",
 
-    "download_minidump_stackwalk": True,
     "tooltool_cache": "/builds/worker/tooltool-cache",
 }
--- a/testing/mozharness/configs/firefox_ui_tests/taskcluster_windows.py
+++ b/testing/mozharness/configs/firefox_ui_tests/taskcluster_windows.py
@@ -6,11 +6,10 @@ import sys
 
 config = {
     "virtualenv_path": 'venv',
     "exes": {
         'python': sys.executable,
         'hg': os.path.join(os.environ['PROGRAMFILES'], 'Mercurial', 'hg')
     },
 
-    "download_minidump_stackwalk": True,
     "download_symbols": "ondemand",
 }
--- a/testing/mozharness/configs/marionette/prod_config.py
+++ b/testing/mozharness/configs/marionette/prod_config.py
@@ -11,17 +11,16 @@ config = {
     "default_actions": [
         'clobber',
         'download-and-extract',
         'create-virtualenv',
         'install',
         'run-tests',
     ],
     "download_symbols": "ondemand",
-    "download_minidump_stackwalk": True,
     "tooltool_cache": "/builds/worker/tooltool-cache",
     "suite_definitions": {
         "marionette_desktop": {
             "options": [
                 "-vv",
                 "--log-raw=%(raw_log_file)s",
                 "--log-errorsummary=%(error_summary_file)s",
                 "--log-html=%(html_report_file)s",
--- a/testing/mozharness/configs/marionette/windows_config.py
+++ b/testing/mozharness/configs/marionette/windows_config.py
@@ -12,17 +12,16 @@ config = {
 
     "default_actions": [
         'clobber',
         'download-and-extract',
         'create-virtualenv',
         'install',
         'run-tests',
     ],
-    "download_minidump_stackwalk": True,
     "download_symbols": "ondemand",
     "suite_definitions": {
         "marionette_desktop": {
             "options": [
                 "-vv",
                 "--log-raw=%(raw_log_file)s",
                 "--log-errorsummary=%(error_summary_file)s",
                 "--log-html=%(html_report_file)s",
--- a/testing/mozharness/configs/marionette/windows_taskcluster_config.py
+++ b/testing/mozharness/configs/marionette/windows_taskcluster_config.py
@@ -15,17 +15,16 @@ config = {
 
     "default_actions": [
         'clobber',
         'download-and-extract',
         'create-virtualenv',
         'install',
         'run-tests',
     ],
-    "download_minidump_stackwalk": True,
     "download_symbols": "ondemand",
     "suite_definitions": {
         "marionette_desktop": {
             "options": [
                 "-vv",
                 "--log-raw=%(raw_log_file)s",
                 "--log-errorsummary=%(error_summary_file)s",
                 "--log-html=%(html_report_file)s",
--- a/testing/mozharness/configs/raptor/android_hw_config.py
+++ b/testing/mozharness/configs/raptor/android_hw_config.py
@@ -9,13 +9,12 @@ config = {
         "populate-webroot",
         "install-chrome",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
     "tooltool_cache": "/builds/tooltool_cache",
     "download_tooltool": True,
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "linux64-minidump_stackwalk",
     "tooltool_servers": ['https://tooltool.mozilla-releng.net/'],
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/linux64/releng.manifest",
 }
--- a/testing/mozharness/configs/raptor/linux64_config_taskcluster.py
+++ b/testing/mozharness/configs/raptor/linux64_config_taskcluster.py
@@ -22,13 +22,12 @@ config = {
     "default_actions": [
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": "/builds/worker/tooltool-cache",
 }
--- a/testing/mozharness/configs/raptor/linux_config.py
+++ b/testing/mozharness/configs/raptor/linux_config.py
@@ -18,13 +18,12 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "install-chrome",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": "/builds/tooltool_cache",
 }
--- a/testing/mozharness/configs/raptor/mac_config.py
+++ b/testing/mozharness/configs/raptor/mac_config.py
@@ -28,13 +28,12 @@ config = {
     ],
     "run_cmd_checks_enabled": True,
     "preflight_run_cmd_suites": [
         SCREEN_RESOLUTION_CHECK,
     ],
     "postflight_run_cmd_suites": [
         SCREEN_RESOLUTION_CHECK,
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "macosx64-minidump_stackwalk",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/macosx64/releng.manifest",
     "tooltool_cache": "/builds/tooltool_cache",
 }
--- a/testing/mozharness/configs/raptor/windows_config.py
+++ b/testing/mozharness/configs/raptor/windows_config.py
@@ -25,17 +25,16 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "install-chrome",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "tooltool_cache": os.path.join('c:\\', 'build', 'tooltool_cache'),
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "python3_manifest": {
         "win32": "python3.manifest",
         "win64": "python3_x64.manifest",
     },
     "env": {
--- a/testing/mozharness/configs/raptor/windows_vm_config.py
+++ b/testing/mozharness/configs/raptor/windows_vm_config.py
@@ -24,17 +24,16 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "install-chrome",
         "create-virtualenv",
         "install",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "tooltool_cache": os.path.join('c:\\', 'build', 'tooltool_cache'),
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "python3_manifest": {
         "win32": "python3.manifest",
         "win64": "python3_x64.manifest",
     },
     "env": {
--- a/testing/mozharness/configs/talos/linux64_config_taskcluster.py
+++ b/testing/mozharness/configs/talos/linux64_config_taskcluster.py
@@ -28,13 +28,12 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "setup-mitmproxy",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": "/builds/worker/tooltool-cache",
 }
--- a/testing/mozharness/configs/talos/linux_config.py
+++ b/testing/mozharness/configs/talos/linux_config.py
@@ -18,13 +18,12 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "setup-mitmproxy",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": "/builds/tooltool_cache",
 }
--- a/testing/mozharness/configs/talos/mac_config.py
+++ b/testing/mozharness/configs/talos/mac_config.py
@@ -28,13 +28,12 @@ config = {
     ],
     "run_cmd_checks_enabled": True,
     "preflight_run_cmd_suites": [
         SCREEN_RESOLUTION_CHECK,
     ],
     "postflight_run_cmd_suites": [
         SCREEN_RESOLUTION_CHECK,
     ],
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "macosx64-minidump_stackwalk",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/macosx64/releng.manifest",
     "tooltool_cache": "/builds/tooltool_cache",
 }
--- a/testing/mozharness/configs/talos/windows_config.py
+++ b/testing/mozharness/configs/talos/windows_config.py
@@ -20,17 +20,16 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "setup-mitmproxy",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "tooltool_cache": os.path.join('c:\\', 'build', 'tooltool_cache'),
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "python3_manifest": {
         "win32": "python3.manifest",
         "win64": "python3_x64.manifest",
     },
     "env": {
--- a/testing/mozharness/configs/talos/windows_taskcluster_config.py
+++ b/testing/mozharness/configs/talos/windows_taskcluster_config.py
@@ -17,17 +17,16 @@ config = {
     "title": socket.gethostname().split('.')[0],
     "default_actions": [
         "populate-webroot",
         "create-virtualenv",
         "install",
         "setup-mitmproxy",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "tooltool_cache": os.path.join('Y:\\', 'tooltool-cache'),
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "python3_manifest": {
         "win32": "python3.manifest",
         "win64": "python3_x64.manifest",
     },
     "env": {
--- a/testing/mozharness/configs/talos/windows_vm_config.py
+++ b/testing/mozharness/configs/talos/windows_vm_config.py
@@ -19,17 +19,16 @@ config = {
         "clobber",
         "download-and-extract",
         "populate-webroot",
         "create-virtualenv",
         "install",
         "setup-mitmproxy",
         "run-tests",
     ],
-    "download_minidump_stackwalk": True,
     "tooltool_cache": os.path.join('c:\\', 'build', 'tooltool_cache'),
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "python3_manifest": {
         "win32": "python3.manifest",
         "win64": "python3_x64.manifest",
     },
     "env": {
--- a/testing/mozharness/configs/unittests/linux_unittest.py
+++ b/testing/mozharness/configs/unittests/linux_unittest.py
@@ -262,17 +262,16 @@ config = {
     "vcs_output_timeout": 1000,
     "minidump_save_path": "%(abs_work_dir)s/../minidumps",
     "unstructured_flavors": {"xpcshell": [],
                              "gtest": [],
                              "mozmill": [],
                              "cppunittest": [],
                              "jittest": [],
                              },
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": MINIDUMP_STACKWALK_PATH,
     "minidump_tooltool_manifest_path": TOOLTOOL_MANIFEST_PATH,
     "tooltool_cache": "/builds/worker/tooltool-cache",
     "download_nodejs": True,
     "nodejs_path": NODEJS_PATH,
     "nodejs_tooltool_manifest_path": NODEJS_TOOLTOOL_MANIFEST_PATH,
     # "log_format": "%(levelname)8s - %(message)s",
 }
--- a/testing/mozharness/configs/unittests/mac_unittest.py
+++ b/testing/mozharness/configs/unittests/mac_unittest.py
@@ -211,16 +211,15 @@ config = {
     "vcs_output_timeout": 1000,
     "minidump_save_path": "%(abs_work_dir)s/../minidumps",
     "unstructured_flavors": {"xpcshell": [],
                              "gtest": [],
                              "mozmill": [],
                              "cppunittest": [],
                              "jittest": [],
                              },
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "macosx64-minidump_stackwalk",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/macosx64/releng.manifest",
     "tooltool_cache": "/builds/tooltool_cache",
     "download_nodejs": True,
     "nodejs_path": "node-osx/bin/node",
     "nodejs_tooltool_manifest_path": "config/tooltool-manifests/macosx64/nodejs.manifest",
 }
--- a/testing/mozharness/configs/unittests/win_taskcluster_unittest.py
+++ b/testing/mozharness/configs/unittests/win_taskcluster_unittest.py
@@ -285,15 +285,14 @@ config = {
     "vcs_output_timeout": 1000,
     "minidump_save_path": "%(abs_work_dir)s/../minidumps",
     "unstructured_flavors": {"xpcshell": [],
                              "gtest": [],
                              "mozmill": [],
                              "cppunittest": [],
                              "jittest": [],
                              },
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "download_nodejs": True,
     "nodejs_path": "node-win32.exe",
     "nodejs_tooltool_manifest_path": "config/tooltool-manifests/win32/nodejs.manifest",
 }
--- a/testing/mozharness/configs/unittests/win_unittest.py
+++ b/testing/mozharness/configs/unittests/win_unittest.py
@@ -237,15 +237,14 @@ config = {
     "vcs_output_timeout": 1000,
     "minidump_save_path": "%(abs_work_dir)s/../minidumps",
     "unstructured_flavors": {"xpcshell": [],
                              "gtest": [],
                              "mozmill": [],
                              "cppunittest": [],
                              "jittest": [],
                              },
-    "download_minidump_stackwalk": True,
     "minidump_stackwalk_path": "win32-minidump_stackwalk.exe",
     "minidump_tooltool_manifest_path": "config/tooltool-manifests/win32/releng.manifest",
     "download_nodejs": True,
     "nodejs_path": "node-win32.exe",
     "nodejs_tooltool_manifest_path": "config/tooltool-manifests/win32/nodejs.manifest",
 }
--- a/testing/mozharness/configs/web_platform_tests/prod_config.py
+++ b/testing/mozharness/configs/web_platform_tests/prod_config.py
@@ -13,15 +13,13 @@ config = {
         "--processes=1",
         "--config=%(test_path)s/wptrunner.ini",
         "--ca-cert-path=%(test_path)s/tests/tools/certs/cacert.pem",
         "--host-key-path=%(test_path)s/tests/tools/certs/web-platform.test.key",
         "--host-cert-path=%(test_path)s/tests/tools/certs/web-platform.test.pem",
         "--certutil-binary=%(test_install_path)s/bin/certutil",
     ],
 
-    "download_minidump_stackwalk": True,
-
     # this would normally be in "exes", but "exes" is clobbered by remove_executables
     "geckodriver": os.path.join("%(abs_test_bin_dir)s", "geckodriver"),
 
     "per_test_category": "web-platform",
 }
--- a/testing/mozharness/configs/web_platform_tests/prod_config_android.py
+++ b/testing/mozharness/configs/web_platform_tests/prod_config_android.py
@@ -13,17 +13,16 @@ config = {
         "--ca-cert-path=%(test_path)s/tests/tools/certs/cacert.pem",
         "--host-key-path=%(test_path)s/tests/tools/certs/web-platform.test.key",
         "--host-cert-path=%(test_path)s/tests/tools/certs/web-platform.test.pem",
         "--certutil-binary=%(xre_path)s/certutil",
         "--product=fennec",
     ],
     "avds_dir": "/builds/worker/workspace/build/.android",
     "binary_path": "/tmp",
-    "download_minidump_stackwalk": True,
     "geckodriver": "%(abs_test_bin_dir)s/geckodriver",
     "hostutils_manifest_path": "testing/config/tooltool-manifests/linux64/hostutils.manifest",
     "log_tbpl_level": "info",
     "log_raw_level": "info",
     "minidump_stackwalk_path": "linux64-minidump_stackwalk",
     "per_test_category": "web-platform",
     "tooltool_cache": os.environ.get("TOOLTOOL_CACHE"),
     "tooltool_servers": ['http://relengapi/tooltool/'],
--- a/testing/mozharness/configs/web_platform_tests/prod_config_windows.py
+++ b/testing/mozharness/configs/web_platform_tests/prod_config_windows.py
@@ -21,15 +21,14 @@ config = {
         "--certutil-binary=%(test_install_path)s/bin/certutil",
     ],
 
     "exes": {
         'python': sys.executable,
         'hg': 'c:/mozilla-build/hg/hg',
     },
 
-    "download_minidump_stackwalk": True,
 
     # this would normally be in "exes", but "exes" is clobbered by remove_executables
     "geckodriver": os.path.join("%(abs_test_bin_dir)s", "geckodriver.exe"),
 
     "per_test_category": "web-platform",
 }
--- a/testing/mozharness/configs/web_platform_tests/prod_config_windows_taskcluster.py
+++ b/testing/mozharness/configs/web_platform_tests/prod_config_windows_taskcluster.py
@@ -46,15 +46,13 @@ config = {
                     'mozharness', 'external_tools', 'machine-configuration.json')
             ],
             'architectures': ['32bit', '64bit'],
             'halt_on_failure': True,
             'enabled': True
         }
     ],
 
-    "download_minidump_stackwalk": True,
-
     # this would normally be in "exes", but "exes" is clobbered by remove_executables
     "geckodriver": os.path.join("%(abs_test_bin_dir)s", "geckodriver.exe"),
 
     "per_test_category": "web-platform",
 }
--- a/testing/mozharness/mozharness/mozilla/testing/testbase.py
+++ b/testing/mozharness/mozharness/mozilla/testing/testbase.py
@@ -640,45 +640,42 @@ Did you run with --create-virtualenv? Is
             return self.minidump_stackwalk_path
 
         c = self.config
         dirs = self.query_abs_dirs()
 
         # This is the path where we either download to or is already on the host
         minidump_stackwalk_path = self.query_minidump_filename()
 
-        if not c.get('download_minidump_stackwalk'):
-            self.minidump_stackwalk_path = minidump_stackwalk_path
-        else:
-            if not manifest:
-                tooltool_manifest_path = self.query_minidump_tooltool_manifest()
-                manifest = os.path.join(dirs.get('abs_test_install_dir',
-                                                 os.path.join(dirs['abs_work_dir'], 'tests')),
-                                        tooltool_manifest_path)
+        if not manifest:
+            tooltool_manifest_path = self.query_minidump_tooltool_manifest()
+            manifest = os.path.join(dirs.get('abs_test_install_dir',
+                                             os.path.join(dirs['abs_work_dir'], 'tests')),
+                                    tooltool_manifest_path)
 
-            self.info('grabbing minidump binary from tooltool')
-            try:
-                self.tooltool_fetch(
-                    manifest=manifest,
-                    output_dir=dirs['abs_work_dir'],
-                    cache=c.get('tooltool_cache')
-                )
-            except KeyError:
-                self.error('missing a required key.')
+        self.info('grabbing minidump binary from tooltool')
+        try:
+            self.tooltool_fetch(
+                manifest=manifest,
+                output_dir=dirs['abs_work_dir'],
+                cache=c.get('tooltool_cache')
+            )
+        except KeyError:
+            self.error('missing a required key.')
 
-            abs_minidump_path = os.path.join(dirs['abs_work_dir'],
-                                             minidump_stackwalk_path)
-            if os.path.exists(abs_minidump_path):
-                self.chmod(abs_minidump_path, 0755)
-                self.minidump_stackwalk_path = abs_minidump_path
-            else:
-                self.warning("minidump stackwalk path was given but couldn't be found. "
-                             "Tried looking in '%s'" % abs_minidump_path)
-                # don't burn the job but we should at least turn them orange so it is caught
-                self.record_status(TBPL_WARNING, WARNING)
+        abs_minidump_path = os.path.join(dirs['abs_work_dir'],
+                                         minidump_stackwalk_path)
+        if os.path.exists(abs_minidump_path):
+            self.chmod(abs_minidump_path, 0755)
+            self.minidump_stackwalk_path = abs_minidump_path
+        else:
+            self.warning("minidump stackwalk path was given but couldn't be found. "
+                         "Tried looking in '%s'" % abs_minidump_path)
+            # don't burn the job but we should at least turn them orange so it is caught
+            self.record_status(TBPL_WARNING, WARNING)
 
         return self.minidump_stackwalk_path
 
     def query_options(self, *args, **kwargs):
         if "str_format_values" in kwargs:
             str_format_values = kwargs.pop("str_format_values")
         else:
             str_format_values = {}