bug 1523104: remote: use fatal error when unable to start HTTPD; r=ochameau
authorAndreas Tolfsen <ato@sny.no>
Thu, 07 Mar 2019 22:13:18 +0000
changeset 521131 4696a88c5274
parent 521130 932d90008fe2
child 521132 1f861b702507
push id10862
push userffxbld-merge
push dateMon, 11 Mar 2019 13:01:11 +0000
treeherdermozilla-beta@a2e7f5c935da [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersochameau
bugs1523104
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1523104: remote: use fatal error when unable to start HTTPD; r=ochameau
remote/RemoteAgent.js
--- a/remote/RemoteAgent.js
+++ b/remote/RemoteAgent.js
@@ -165,21 +165,20 @@ class ParentRemoteAgent {
       return;
     }
 
     await Observer.once("sessionstore-windows-restored");
     await this.tabs.start();
 
     try {
       this.listen(addr);
-    } catch ({message}) {
+    } catch (e) {
       this.close();
-      log.fatal(`Unable to start remote agent on ${addr.spec}: ${message}`);
-      cmdLine.preventDefault = true;
-    }
+      throw new FatalError(`Unable to start remote agent on ${addr.spec}: ${e.message}`, e);
+     }
   }
 
   get helpInfo() {
     return "  --remote-debugger [<host>][:<port>] Start the Firefox remote agent, which is \n" +
            "                     a low-level debugging interface based on the CDP protocol.\n" +
            "                     Defaults to listen on localhost:9222.\n";
   }