Bug 1207696 Part 4h - Don't record chaos mode counters, r=froydnj.
authorBrian Hackett <bhackett1024@gmail.com>
Sat, 21 Jul 2018 14:25:36 +0000
changeset 482768 44b62ee96921df348dff53cc505db58132eeba03
parent 482767 99479560fb28b06474e61a365685abada9c1446d
child 482769 f007143a96eb464f6d7b3873bf1722b11e6634fe
push id9719
push userffxbld-merge
push dateFri, 24 Aug 2018 17:49:46 +0000
treeherdermozilla-beta@719ec98fba77 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1207696
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1207696 Part 4h - Don't record chaos mode counters, r=froydnj.
mfbt/ChaosMode.cpp
mfbt/ChaosMode.h
--- a/mfbt/ChaosMode.cpp
+++ b/mfbt/ChaosMode.cpp
@@ -5,13 +5,13 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "mozilla/ChaosMode.h"
 
 namespace mozilla {
 
 namespace detail {
 
-Atomic<uint32_t> gChaosModeCounter(0);
+Atomic<uint32_t, SequentiallyConsistent, recordreplay::Behavior::DontPreserve> gChaosModeCounter(0);
 ChaosFeature gChaosFeatures = None;
 
 } /* namespace detail */
 } /* namespace mozilla */
--- a/mfbt/ChaosMode.h
+++ b/mfbt/ChaosMode.h
@@ -28,17 +28,19 @@ enum ChaosFeature {
   // Iterate over hash tables in random order.
   HashTableIteration = 0x10,
   // Randomly refuse to use cached version of image (when allowed by spec).
   ImageCache = 0x20,
   Any = 0xffffffff,
 };
 
 namespace detail {
-extern MFBT_DATA Atomic<uint32_t> gChaosModeCounter;
+extern MFBT_DATA Atomic<uint32_t,
+                        SequentiallyConsistent,
+                        recordreplay::Behavior::DontPreserve> gChaosModeCounter;
 extern MFBT_DATA ChaosFeature gChaosFeatures;
 } // namespace detail
 
 /**
  * When "chaos mode" is activated, code that makes implicitly nondeterministic
  * choices is encouraged to make random and extreme choices, to test more
  * code paths and uncover bugs.
  */